Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added generic animated loader and message #321

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

vishnuszipstack
Copy link
Contributor

What

  • While creating new organization, The UI screen looks like page is hanging because there is no indication.

Why

  • For improving user experience

How

  • Added generic loader component
  • Added animation for the logo and added color dots
  • Added generic message for the loader "Please wait while we prepare your session. This might take a
    minute."

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No, Added improvements for current loading.

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@tahierhussain tahierhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

P.S.: We need to create an SVG for the loader so that it is convenient to use in other places. I had a discussion with @vishnuszipstack regarding this. We can take it up in the near future, as it is a good-to-have change.

cc: @nehabagdia

@nehabagdia nehabagdia merged commit c04acbd into main May 8, 2024
4 checks passed
@nehabagdia nehabagdia deleted the fix/generic-loader branch May 8, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants