collect-only incompatible with nosedep

[chickenandpork]

nosetests -v -w ${test_subdir} --collect-only -s ./test.py:testClassName would be used to collect the names f the tests but not actually run them. It's useful for listing out generated test names using nose-parameterized

With nosedep, the following no longer just lists tests, but tries to execute them:

nosetests --with-nosedep -v -w ${test_subdir} --collect-only -s ./test.py:testClassName

This seems to be unexpected behavior: I would expect --collect-only to still only collect the names of tests.

[Zitrax]

Hi and thanks for your report. I added simple unit tests for this since there were none, but they pass without further changes.

I haven't investigated the syntax of specifying the classname in the end that you use yet though, does it have any effect you regarding this?

If not is it possible that you could provide me with some simple sample code that reproduce the issue?

[chickenandpork]

Based on your decorated_functional_dep_skip.py:

from unittest import SkipTest, TestCase
from nosedep import depends

class decorated_functional_dep_skip(TestCase):

    @classmethod
    def setupClass(cls):
        assert False

    @depends(after='test_dfds_b')
    def test_dfds_a():
        pass

    def test_dfds_b():
        raise AssertionError("UNGA HAZA")

    def test_dfds_c():
        assert False
        pass

    @depends(after='not_existing_test')
    def test_dfds_d():
        pass

    def test_dfds_e():
        raise SkipTest('skippington')

    @depends(after=test_dfds_e)
    def test_dfds_f():
        pass

Execute with: nosetests --with-xunit --with-nosedep -v --collect-only test.py

You'll notice that the setupClass() method gets executed despite --collect-only, triggering the failed assertion. Without --with-nosedep the setupClass() is not executed.

[Zitrax]

I see, thanks for the update. I'll have a look.

[Zitrax]

As can be seen in the doc prepareTestLoader() can only be used by a single plugin. Thus this seem to mean that collect and nosedep are not compatible together. I added a commit that will detect if collect is in use and then nosedep disables itself.

That means you can't collect to get the tests printed in dependency order of course, but at least there should not be any surprises of running the setup/teardown when collecting.

[chickenandpork]

Thanks! I’ll check on Monday :)

…

On Nov 10, 2018, at 07:01, Zitrax ***@***.***> wrote: As can be seen in the doc prepareTestLoader() can only be used by a single plugin. Thus this seem to mean that collect and nosedep are not compatible together. I added a commit that will detect if collect is in use and then nosedep disables itself. That means you can't collect to get the tests printed in dependency order of course, but at least there should not be any surprises of running the setup/teardown when collecting. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[chickenandpork]

FIXED :)

Hand-applying your nosedep.py change, I see a better result. Are you willing to ship this change (even as a point/patch related like 0.6.1) so we can update our requirements.txt ? Thanks!

[Zitrax]

Thanks for reporting and testing, I'll look into releasing.

[Zitrax]

Released as 0.7.

[chickenandpork]

Not so fast; I might have another failure case. Let me cook an example.

…

On Mon, Nov 12, 2018 at 1:04 PM Zitrax ***@***.***> wrote: Thanks for reporting and testing, I'll look into releasing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACNonBB997d9K9wUlc6C5o7XjsUYC1nxks5uud27gaJpZM4YEdml> .

-- allanc@chickenandporn.com "金鱼" http://linkedin.com/in/goldfish