Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font size is divided in half #13

Closed
dmgreene opened this issue Dec 11, 2013 · 3 comments
Closed

font size is divided in half #13

dmgreene opened this issue Dec 11, 2013 · 3 comments

Comments

@dmgreene
Copy link

Again, love the plugin. I noticed that if I used font_size 20, the font in word will actually end up being font size 10. Same for 40, it becomes 20 in word.

@Ziv-Barber
Copy link
Owner

Thanks, I'll check it.
Also I'll see what I can do with the line break.

Ziv

On Thu, Dec 12, 2013 at 12:46 AM, Dan notifications@github.com wrote:

Again, love the plugin. I noticed that if I used font_size 20, the font in
word will actually end up being font size 10. Same for 40, it becomes 20 in
word.


Reply to this email directly or view it on GitHubhttps://github.com//issues/13
.

@dmgreene
Copy link
Author

Thanks. You are awesome. :)

-Dan

From: Ziv Barber <notifications@github.commailto:notifications@github.com>
Reply-To: Ziv-Barber/officegen <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, December 11, 2013 6:48 PM
To: Ziv-Barber/officegen <officegen@noreply.github.commailto:officegen@noreply.github.com>
Cc: Dan Greene <daniel.m.greene@lmco.commailto:daniel.m.greene@lmco.com>
Subject: EXTERNAL: Re: [officegen] font size is divided in half (#13)

Thanks, I'll check it.
Also I'll see what I can do with the line break.

Ziv

On Thu, Dec 12, 2013 at 12:46 AM, Dan <notifications@github.commailto:notifications@github.com> wrote:

Again, love the plugin. I noticed that if I used font_size 20, the font in
word will actually end up being font size 10. Same for 40, it becomes 20 in
word.


Reply to this email directly or view it on GitHubhttps://github.com//issues/13
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-30376756.

@magicienap
Copy link
Contributor

Hi,

In fact, when we look in the specification, the size is "specified in half-points" (section 17.3.2.38, page 309 of the first part). I made a modification in the source code that corrects the behaviour. I will do a pull request. Also, I created a library to generate docx documents in Ruby (https://github.com/magicienap/docx_generator). Maybe it can be useful! I wanted to port it to JavaScript, but I discovered this project. I would like to take part of it.

Ziv-Barber added a commit that referenced this issue Jan 9, 2014
Fix #13 and correct an example in the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants