Skip to content

Commit

Permalink
Rollback unique fields on username/email.
Browse files Browse the repository at this point in the history 
It's breaking updates to users.
  • Loading branch information
@andrew13
andrew13 committed Apr 3, 2013
1 parent fb931ef commit 5e75221
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/Zizaco/Confide/ConfideUser.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ class ConfideUser extends Ardent implements UserInterface {
* @var array
*/
public static $rules = array(
'username' => 'unique:users',
'email' => 'required|email|unique:users',
'email' => 'required|email',
'password' => 'required|between:4,11|confirmed',
);

Expand Down

8 comments on commit 5e75221

@travisolbrich
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it breaking updates?

@andrew13
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to the user.

@travisolbrich
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can see that from "It's breaking updates to users." How is it breaking updates to the user? What needs to be done?

@andrew13
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to the ardent issue laravel-ardent/ardent#37

@travisolbrich
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why not just put some logic in the save() function to handle this? I did it and it seems to work well.

@andrew13
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, please share and I'll be happy to take a look 👍

@andrew13
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have a chance to share?

@travisolbrich
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will, but it's going to be a week or so. Dealing with finals and move-out.

Please sign in to comment.