Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.6 - Paging buttons have stopped working #148

Closed
thesilverbadger opened this issue Jul 13, 2015 · 2 comments
Closed

0.5.6 - Paging buttons have stopped working #148

thesilverbadger opened this issue Jul 13, 2015 · 2 comments
Assignees
Milestone

Comments

@thesilverbadger
Copy link

0.5.6 has fixed our issue with the page param not being reset to 1 on a search being triggered, however this seems to have introduced a new bug whereby the pagination buttons no longer page through a remote resultset.

I think I've tracked the issue down to updateServerSideResource, which fires when the pagination buttons are clicked, but as initNow is always false (we don't want the search triggering when the page is initalised), resourceCallback is never called. Our search button is hooked up to a callback, and this triggers correctly (and seems to take the correct params too, so if I've clicked page 5, and then click search, I get results from page 5).

$scope.reloadCallback = function () { };
$scope.search = function () {
  $scope.reloadCallback();
};

I'm of work now for a week (:tropical_drink: :sunny:), so I'll try to provide a demo when I return if this isn't enough info.

Cheers 😄

@Zizzamia Zizzamia added this to the Version 0.5.7 milestone Jul 13, 2015
@Zizzamia Zizzamia self-assigned this Jul 13, 2015
Zizzamia added a commit that referenced this issue Jul 26, 2015
Zizzamia added a commit that referenced this issue Jul 26, 2015
Zizzamia added a commit that referenced this issue Jul 26, 2015
@thesilverbadger
Copy link
Author

Looks fixed to me, many thanks :)

@Zizzamia
Copy link
Owner

:) thankYou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants