Conditionally make calls to PerformanceObserver.takeRecords which doesnt exist in Safari #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h doesnt exist in Safari
ernieturner
commented
Aug 24, 2020
| perfObservers[3].takeRecords(); | ||
| if (typeof perfObservers[3].takeRecords === 'function') { | ||
| perfObservers[3].takeRecords(); | ||
| } |
There was a problem hiding this comment.
I assumed that the calls to logMetric and poDisconnect should still happen in this scenario, but let me know if that isn't the case.
There was a problem hiding this comment.
Interesting point, let me think out loud the logic.
Actually more I re-think the logic out loud more I think there is one more bug to solve 🤦🏻♂️
The final records are probably never saved in cls.value.
Zizzamia
reviewed
Aug 27, 2020
| @@ -46,5 +46,13 @@ describe('firstInput', () => { | |||
| expect(spy).toHaveBeenCalledWith(2, 'cls'); | |||
| expect(spy).toHaveBeenCalledWith(3, 'tbt'); | |||
| }); | |||
|
|
|||
| it('should conditionally call takeRecords', () => { | |||
|
@ernieturner just published v5.2.0 with your fix. Thank you again 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of other Prettier changes in this changeset in files that I assume haven't been saved since the config was introduced.