Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value validation and formatting to NormalWriter and FastWriter #50

Closed
3 tasks done
Zncl2222 opened this issue May 8, 2024 · 0 comments · Fixed by #51
Closed
3 tasks done

Add value validation and formatting to NormalWriter and FastWriter #50

Zncl2222 opened this issue May 8, 2024 · 0 comments · Fixed by #51
Assignees
Labels
bug Something isn't working refactor
Milestone

Comments

@Zncl2222
Copy link
Owner

Zncl2222 commented May 8, 2024

Currently, value validation is only implemented in the __setitem__ method of the worksheet. It does not work in the row_append methods of FastWriter and NormalWriter. Moreover, np.float64 is not supported in msgspec, so we should convert it to a Python float when isinstance(value, float) is True.

  • Abstract the functionality of value_validation and rename it, as well as style_validadtion.
  • Add value_validation to FastWriter and NormalWriter
  • If isinstance(value, float) is True, convert the value to python float to prevent the np.float64 issue.
@Zncl2222 Zncl2222 added bug Something isn't working refactor labels May 8, 2024
@Zncl2222 Zncl2222 added this to the v0.0.7 milestone May 8, 2024
@Zncl2222 Zncl2222 self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant