Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx&Refactor: add value validation to NormalWriter and FastWriter #51

Merged
merged 2 commits into from
May 8, 2024

Conversation

Zncl2222
Copy link
Owner

@Zncl2222 Zncl2222 commented May 8, 2024

No description provided.

@Zncl2222 Zncl2222 added bug Something isn't working test unittest refactor labels May 8, 2024
@Zncl2222 Zncl2222 added this to the v0.0.7 milestone May 8, 2024
@Zncl2222 Zncl2222 self-assigned this May 8, 2024
Copy link

codacy-production bot commented May 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -5.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (03f11f6) 1058 1035 97.83%
Head commit (b3e6fe6) 1067 (+9) 1044 (+9) 97.84% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#51) 20 20 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (03f11f6) to head (b3e6fe6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   97.53%   91.88%   -5.66%     
==========================================
  Files          11        4       -7     
  Lines        1013      271     -742     
==========================================
- Hits          988      249     -739     
+ Misses         16       13       -3     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zncl2222 Zncl2222 linked an issue May 8, 2024 that may be closed by this pull request
3 tasks
@Zncl2222 Zncl2222 merged commit 13e07ce into main May 8, 2024
22 checks passed
@Zncl2222 Zncl2222 deleted the fix/validation branch May 8, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor test unittest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add value validation and formatting to NormalWriter and FastWriter
2 participants