Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor&Feature: move writer's function and make style only need to regist once #22

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

Zncl2222
Copy link
Owner

@Zncl2222 Zncl2222 commented Mar 3, 2024

  1. Move the function that related to the writer to writer.py
  2. Make sylte as a parent class attributets, so user only need to regist style once.
  3. Delete the Problems that I solve in readme
  4. Upgrade the version of the action workflow.
  5. Add unittest for the new function

…class memory

1. Move the writer related function to writer.py

2. Create style_map as parent class attribute, so the style can shared between from different
writer class
@Zncl2222 Zncl2222 added documentation Improvements or additions to documentation enhancement New feature or request ci/cd/build ci, cd or build refactor labels Mar 3, 2024
@Zncl2222 Zncl2222 added this to the v0.0.5 milestone Mar 3, 2024
@Zncl2222 Zncl2222 self-assigned this Mar 3, 2024
@Zncl2222 Zncl2222 added the test unittest label Mar 3, 2024
Copy link

codacy-production bot commented Mar 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8aa34b6) 471 461 97.88%
Head commit (15ef745) 488 (+17) 478 (+17) 97.95% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22) 66 66 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (8aa34b6) to head (15ef745).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   98.08%   98.16%   +0.08%     
==========================================
  Files           7        7              
  Lines         470      491      +21     
==========================================
+ Hits          461      482      +21     
  Misses          7        7              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zncl2222 Zncl2222 merged commit a9e892b into main Mar 3, 2024
22 checks passed
@Zncl2222 Zncl2222 deleted the refactor/writer_and_style branch March 3, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd/build ci, cd or build documentation Improvements or additions to documentation enhancement New feature or request refactor test unittest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants