Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toponline.php site_title and type #347

Merged
merged 2 commits into from Mar 14, 2019
Merged

Conversation

gregorecruzeiro
Copy link
Contributor

@gregorecruzeiro gregorecruzeiro commented Mar 14, 2019

Parse error: syntax error, unexpected 'site_title' (T_STRING), expecting ',' or ';' in toponline.php on line 40
Notice: Undefined index: type in toponline.php on line 10

Parse error: syntax error, unexpected 'site_title' (T_STRING), expecting ',' or ';' in C:\xampp\htdocs\znote\toponline.php on line 40
Notice: Undefined index: type in C:\xampp\htdocs\znote\toponline.php on line 10
Copy link
Owner

@Znote Znote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, I found one issue I would like you to fix before I merge this. See the noted code suggestion.

toponline.php Outdated Show resolved Hide resolved
Copy link
Contributor Author

@gregorecruzeiro gregorecruzeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions accepted

@Znote Znote merged commit e8a57cb into Znote:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants