Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update exploding-trees #55

Merged
merged 3 commits into from
Jun 5, 2023
Merged

update exploding-trees #55

merged 3 commits into from
Jun 5, 2023

Conversation

chayleaf
Copy link
Contributor

@chayleaf chayleaf commented Jun 1, 2023

  • add compatibility for mods that add trees (like alien biomes)
  • make robots also explode trees (but add a setting to disable it)
  • make killing a tree always explode it (but add a setting to override the probability)
  • add Russian and Japanese locale (the only two langs other than English that I know)

Side note, I think you should change the repository to not have the version number in the mod name. This will make the commit diffs way nicer.

- add compatibility for mods that add trees
- make robots also explode trees (but add a setting to disable it)
- make killing a tree always explode it (but add a setting to override
  the probability)
also update English localization to make more sense with the new mod
changes
@Zomis Zomis merged commit 1602292 into Zomis:main Jun 5, 2023
1 check passed
@Zomis
Copy link
Owner

Zomis commented Jun 5, 2023

Thanks for the pull request.

I haven't bothered before about the version numbers in the mod names, even though I knew that they weren't needed. Because I built my Jenkinsfile to take care of the version updating, back in the day when the version number was required in the folder name.

Now I had a reason to update my Jenkinsfile though to also support mods without version number in folder name, thanks for that motivation :)

I have released a new version of the mod now, thanks!

@Zomis
Copy link
Owner

Zomis commented Jun 5, 2023

Btw... I can't believe someone is actually seriously playing with that mod 😂 I made it just for the fun of the quote.

@chayleaf
Copy link
Contributor Author

chayleaf commented Jun 5, 2023

I'm not actually playing with it, I just randomly tried it with SE installed lol

@Zomis
Copy link
Owner

Zomis commented Jun 5, 2023

@chayleaf That makes more sense. Thanks for the pull request anyway 😄

@riven8192
Copy link

riven8192 commented Jun 6, 2023

in control.lua i see this line:
local position = get_random_position(box, 0.8, 0.5)

while the function only defines the 'box' parameter, so it ignores the 2nd and 3rd argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants