Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionability: Added rosetta zones pluggin #649

Merged
merged 3 commits into from
May 23, 2023
Merged

Functionability: Added rosetta zones pluggin #649

merged 3 commits into from
May 23, 2023

Conversation

bizk
Copy link

@bizk bizk commented May 22, 2023

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

🔗 zboto Link

@bizk bizk marked this pull request as ready for review May 22, 2023 21:23
@bizk bizk changed the title Misc/exp plugin Functionability: Added rosetta zones pluggin May 22, 2023
@github-actions
Copy link

@bizk your pull request is missing a changelog!

@bizk bizk merged commit 6d45f44 into main May 23, 2023
36 of 49 checks passed
github-actions bot pushed a commit that referenced this pull request May 23, 2023
* poc plugin

* plugins with a go.mod

---------

Co-authored-by: rllola <rllola80@gmail.com>
@jleni jleni deleted the misc/exp-plugin branch July 20, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants