Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos hub plugin and refactor for plugins module loading #653

Merged
merged 10 commits into from
May 26, 2023

Conversation

bizk
Copy link

@bizk bizk commented May 23, 2023

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

馃敆 zboto Link

@bizk bizk merged commit 44229b2 into main May 26, 2023
31 of 43 checks passed
github-actions bot pushed a commit that referenced this pull request May 26, 2023
* poc plugin

* plugins with a go.mod

* Added cosmos-hub plugin

* cosmos-hub plugin working and added parsing from CLI params

* added tests, refactored code to make it cleaner

* added documentation

* added documentation

* added the missing interfaces for osmosis

---------

Co-authored-by: rllola <rllola80@gmail.com>
@rllola rllola deleted the misc/exp-plugin-cosmos branch May 26, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants