Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Schnorr signatures for privacy and storage improvements #670

Closed
wants to merge 31 commits into from

Conversation

bizk
Copy link

@bizk bizk commented Jul 28, 2023

Description

Closes: cosmos#7315


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

🔗 zboto Link

@bizk bizk changed the title Zondax/feature/schnorr feat: Schnorr signatures for privacy and storage improvements Jul 28, 2023
Signed-off-by: bizk <santiago.yanzon1999@gmail.com>
@bizk bizk marked this pull request as ready for review August 1, 2023 20:52
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

@bizk your pull request is missing a changelog!

crypto/keys/schnorr/schnorr.go Fixed Show fixed Hide fixed
crypto/keys/schnorr/keys.pb.go Dismissed Show dismissed Hide dismissed
@bizk bizk closed this Aug 15, 2023
@bizk bizk deleted the zondax/feature/schnorr branch October 10, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant