[breaking changes] - consolidate addresses to robust type - group fees data into tx itself #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
force-pushed
the
feat/new-features
branch
from
842486f
to
d7552b1
Compare
emmanuelm41
force-pushed
the
feat/new-features
branch
2 times, most recently
from
c51dc63
to
c936c59
Compare
* Unified fees txs * update tests * change name * comment test * Update v1 parser * tests
* consolidate all addresses to robust format * Increase test timeout * Consolidate robust address * Tests * Refactor on consolidate addresses * more changes * more changes * More changes * minor changes * enhance ensurerobustAddress
* make zcache ttl configurable * make robust addresses consolidation process optional * fix tests * fix linter * condense code into generic function * cover a missing case for addresses robust consolidation process
* refactor fn to make it more generic * refactor FeesData struct * consolidate miner address to robust on fees data * extract transaction fess calculation to function * fix lint
Bumps [github.com/zondax/golem](https://github.com/zondax/golem) from 0.14.1 to 0.14.4. - [Release notes](https://github.com/zondax/golem/releases) - [Commits](Zondax/golem@v0.14.1...v0.14.4) --- updated-dependencies: - dependency-name: github.com/zondax/golem dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
emmanuelm41
force-pushed
the
feat/new-features
branch
from
c936c59
to
34db2ba
Compare
emmanuelm41
changed the title
emmanuelm41
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃敆 zboto Link