This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Set 0 as value to send to actors and add param to handle specific methods #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
reviewed
Feb 8, 2023
Comment on lines
+83
to
88
| function universalReceiverHook(VerifRegTypes.UniversalReceiverParams memory params) internal returns (VerifRegTypes.AllocationsResponse memory) { | ||
| bytes memory raw_request = params.serializeUniversalReceiverParams(); | ||
|
|
||
| bytes memory raw_response = Actor.call( | ||
| VerifRegTypes.UniversalReceiverMethodNum, | ||
| VerifRegTypes.ActorID, | ||
| raw_request, | ||
| Misc.CBOR_CODEC, | ||
| msg.value, | ||
| false | ||
| ); | ||
| bytes memory raw_response = Actor.call(VerifRegTypes.UniversalReceiverMethodNum, VerifRegTypes.ActorID, raw_request, Misc.CBOR_CODEC, 0, false); | ||
|
|
||
| bytes memory result = Actor.readRespData(raw_response); |
There was a problem hiding this comment.
I don't think we need this method here at all. AFAIK, this is used by some standards to validate that the contract can receive tokens, but it does not need to be exposed to the user on a specific actor. If anything, I would create a helper function that allows the dev to call the universal receiver hook on any address they choose.
There was a problem hiding this comment.
The function was marked to be exported as far as I remember. We can remove it in another PR if necessary though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #185
馃敆 zboto Link