This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Rename the "call actor" read_only parameter to static_call
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this will help users understand how to staticcall a native actor. I've also documented _why_ this uses delegatecall internally to make it clear that we're not delegatecalling the target actor.
|
|
emmanuelm41
approved these changes
Feb 24, 2023
|
@Stebalien I like it! |
longfeiWan9
pushed a commit
to longfeiWan9/filecoin-solidity
that referenced
this pull request
Mar 7, 2023
…x#302) Hopefully this will help users understand how to staticcall a native actor. I've also documented _why_ this uses delegatecall internally to make it clear that we're not delegatecalling the target actor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will help users understand how to staticcall a native actor. I've also documented why this uses delegatecall internally to make it clear that we're not delegatecalling the target actor.
None of these changes are critical and feel free to close this PR if they don't make sense and/or don't help to clarify the situation.
🔗 zboto Link