Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

create FilAddress struct to replace bytes #308

Merged
merged 15 commits into from
Feb 25, 2023
Merged

create FilAddress struct to replace bytes #308

merged 15 commits into from
Feb 25, 2023

Conversation

emmanuelm41
Copy link
Member

@emmanuelm41 emmanuelm41 commented Feb 24, 2023 •
edited by zboto bot
Loading

closes #241
closes #287

🔗 zboto Link

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25071712
universal_receiver_hook 4795028

Datacap actor

Function Gas
name 5681261
symbol 5434697
total_supply 7447454
balance 6669671
allowance 7806963
transfer 17399943
transfer_from 25118589
burn 10892758
burn_from 18049841
allowance 11094814
increase_allowance 13809870
decrease_allowance 13801903
revoke_allowance 12357639

Init actor

Function Gas
exec 19647831
exec4 6614992

Market actor

Function Gas
publish_storage_deals 49234174
add_balance 7569888
withdraw_balance 10352134
get_balance 11752335
get_deal_data_commitment 10819456
get_deal_client 6106171
get_deal_provider 6106223
get_deal_label 10920483
get_deal_term 6749293
get_deal_total_price 8189283
get_deal_client_collateral 8008090
get_deal_provider_collateral 8003610
get_deal_verified 6026329
get_deal_activation 6783077

Power actor

Function Gas
miner_count 4771753
network_raw_power 5212183
miner_raw_power 6721053
miner_consensus_count 4785857

Precompiles actor

Function Gas
resolve_address 2409278
lookup_delegated_address (empty response) 2326979
lookup_delegated_address (address found) 2413983
resolve_eth_address 2437402

Send actor

Function Gas
send (actor id) 3240946
send (address) 3240946

Verifreg actor

Function Gas
add_verified_client 13258818
get_claims 9996187
extend_claim_term 11317063
remove_expired_allocations 12947375
remove_expired_claims 11317063

1 similar comment
@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25071712
universal_receiver_hook 4795028

Datacap actor

Function Gas
name 5681261
symbol 5434697
total_supply 7447454
balance 6669671
allowance 7806963
transfer 17399943
transfer_from 25118589
burn 10892758
burn_from 18049841
allowance 11094814
increase_allowance 13809870
decrease_allowance 13801903
revoke_allowance 12357639

Init actor

Function Gas
exec 19647831
exec4 6614992

Market actor

Function Gas
publish_storage_deals 49234174
add_balance 7569888
withdraw_balance 10352134
get_balance 11752335
get_deal_data_commitment 10819456
get_deal_client 6106171
get_deal_provider 6106223
get_deal_label 10920483
get_deal_term 6749293
get_deal_total_price 8189283
get_deal_client_collateral 8008090
get_deal_provider_collateral 8003610
get_deal_verified 6026329
get_deal_activation 6783077

Power actor

Function Gas
miner_count 4771753
network_raw_power 5212183
miner_raw_power 6721053
miner_consensus_count 4785857

Precompiles actor

Function Gas
resolve_address 2409278
lookup_delegated_address (empty response) 2326979
lookup_delegated_address (address found) 2413983
resolve_eth_address 2437402

Send actor

Function Gas
send (actor id) 3240946
send (address) 3240946

Verifreg actor

Function Gas
add_verified_client 13258818
get_claims 9996187
extend_claim_term 11317063
remove_expired_allocations 12947375
remove_expired_claims 11317063

@emmanuelm41 emmanuelm41 merged commit 5431969 into master Feb 25, 2023
@emmanuelm41 emmanuelm41 deleted the feat/address-types branch February 25, 2023 18:28
@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25071712
universal_receiver_hook 4795028

Miner actor

Datacap actor

Function Gas
name 5681261
symbol 5434697
total_supply 7447454
balance 6669671
allowance 7806963
transfer 17399943
transfer_from 25118589
burn 10892758
burn_from 18049841
allowance 11094814
increase_allowance 13809870
decrease_allowance 13801903
revoke_allowance 12357639

Init actor

Function Gas
exec 19647831
exec4 6614992

Market actor

Function Gas
publish_storage_deals 49234174
add_balance 7569888
withdraw_balance 10352134
get_balance 11752335
get_deal_data_commitment 10819456
get_deal_client 6106171
get_deal_provider 6106223
get_deal_label 10920483
get_deal_term 6749293
get_deal_total_price 8189283
get_deal_client_collateral 8008090
get_deal_provider_collateral 8003610
get_deal_verified 6026329
get_deal_activation 6783077

Power actor

Function Gas
miner_count 4771753
network_raw_power 5212183
miner_raw_power 6721053
miner_consensus_count 4785857

Precompiles actor

Function Gas
resolve_address 2409278
lookup_delegated_address (empty response) 2326979
lookup_delegated_address (address found) 2413983
resolve_eth_address 2437402

Send actor

Function Gas
send (actor id) 3240946
send (address) 3240946

Verifreg actor

Function Gas
add_verified_client 13258818
get_claims 9996187
extend_claim_term 11317063
remove_expired_allocations 12947375
remove_expired_claims 11317063

longfeiWan9 pushed a commit to longfeiWan9/filecoin-solidity that referenced this pull request Mar 7, 2023
@emmanuelm41 @longfeiWan9
create FilAddress struct to replace bytes (Zondax#308)
c209ef7 
* feat: create FilAddress struct to replace bytes
* feat: add some utility functions for FilAddress
* fix init tests
* feat: add some extra checks for other types
* feat: simplify method parameters on datacap actor
* fix: make datacap test work again
* fix market tests
* feat: simplify market api methods
* fix verified registry actor tests
* feat: simplify miner actor methods
* fix miner actor tests
* add missing gas result for miner actor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@snissn snissn snissn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More instances of bytes vs id addresses in inputs and Structs Introduce an Address user-defined type
2 participants
@emmanuelm41 @snissn