Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

feat: add leb128 encoding feature #315

Merged
merged 4 commits into from
Feb 27, 2023
Merged

feat: add leb128 encoding feature #315

merged 4 commits into from
Feb 27, 2023

Conversation

rllola
Copy link
Contributor

@rllola rllola commented Feb 25, 2023 •
edited
Loading

  • implement encoding of uint64
  • tests (1024 tests)

closes #241

🔗 zboto Link

@rllola rllola marked this pull request as draft February 25, 2023 22:16
@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25095648
universal_receiver_hook 4818965

Miner actor

Function Gas
change_owner_address 7430491
get_beneficiary 9798824
change_beneficiary 8729879
get_owner 7407697
get_available_balance 5881102
get_vesting_funds 6084734
repay_debt 6324731
confirm_change_worker_address 6233869
get_peer_id 6518998
get_multiaddresses 7043316
change_worker_address 8915609
is_controlling_address 6505135
get_sector_size 5796009
change_multiaddresses 8029671
change_peer_id 7605795
withdraw_balance 8444077

Datacap actor

Function Gas
name 5701200
symbol 5454636
total_supply 7467393
balance 6689611
allowance 7826902
transfer 17419883
transfer_from 25138529
burn 10912697
burn_from 18069780
allowance 11114753
increase_allowance 13829809
decrease_allowance 13821842
revoke_allowance 12377579

Init actor

Function Gas
exec 19750022
exec4 6769021

Market actor

Function Gas
publish_storage_deals 49372504
add_balance 7601580
withdraw_balance 10383734
get_balance 11791187
get_deal_data_commitment 10851148
get_deal_client 6137863
get_deal_provider 6137915
get_deal_label 10948619
get_deal_term 6780985
get_deal_total_price 8220975
get_deal_client_collateral 8039782
get_deal_provider_collateral 8035302
get_deal_verified 6058021
get_deal_activation 6814769

Power actor

Function Gas
miner_count 4791344
network_raw_power 5231774
miner_raw_power 6740644
miner_consensus_count 4805448

Precompiles actor

Function Gas
resolve_address 2512561
lookup_delegated_address (empty response) 2335624
lookup_delegated_address (address found) 2422628
resolve_eth_address 2446047

Send actor

Function Gas
send (actor id) 3277438
send (address) 3591742

Verifreg actor

Function Gas
add_verified_client 13285796
get_claims 10045653
extend_claim_term 11443457
remove_expired_allocations 12981849
remove_expired_claims 11443457

emmanuelm41
emmanuelm41 reviewed Feb 26, 2023
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯 💯

@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25095648
universal_receiver_hook 4818965

Miner actor

Function Gas
change_owner_address 7430491
get_beneficiary 9798824
change_beneficiary 8729879
get_owner 7407697
get_available_balance 5881102
get_vesting_funds 6084734
repay_debt 6324731
confirm_change_worker_address 6233869
get_peer_id 6518998
get_multiaddresses 7043316
change_worker_address 8915609
is_controlling_address 6505135
get_sector_size 5796009
change_multiaddresses 8029671
change_peer_id 7605795
withdraw_balance 8444077

Datacap actor

Function Gas
name 5701200
symbol 5454636
total_supply 7467393
balance 6689611
allowance 7826902
transfer 17419883
transfer_from 25138529
burn 10912697
burn_from 18069780
allowance 11114753
increase_allowance 13829809
decrease_allowance 13821842
revoke_allowance 12377579

Init actor

Function Gas
exec 19750022
exec4 6769021

Market actor

Function Gas
publish_storage_deals 49372504
add_balance 7601580
withdraw_balance 10383734
get_balance 11791187
get_deal_data_commitment 10851148
get_deal_client 6137863
get_deal_provider 6137915
get_deal_label 10948619
get_deal_term 6780985
get_deal_total_price 8220975
get_deal_client_collateral 8039782
get_deal_provider_collateral 8035302
get_deal_verified 6058021
get_deal_activation 6814769

Power actor

Function Gas
miner_count 4791344
network_raw_power 5231774
miner_raw_power 6740644
miner_consensus_count 4805448

Precompiles actor

Function Gas
resolve_address 2512561
lookup_delegated_address (empty response) 2335624
lookup_delegated_address (address found) 2422628
resolve_eth_address 2446047

Send actor

Function Gas
send (actor id) 3277438
send (address) 3591742

Verifreg actor

Function Gas
add_verified_client 13285796
get_claims 10045653
extend_claim_term 11443457
remove_expired_allocations 12981849
remove_expired_claims 11443457

@rllola rllola marked this pull request as ready for review February 27, 2023 13:37
@github-actions
Copy link

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25095648
universal_receiver_hook 4818965

Miner actor

Function Gas
change_owner_address 7430491
get_beneficiary 9798824
change_beneficiary 8729879
get_owner 7407697
get_available_balance 5881102
get_vesting_funds 6084734
repay_debt 6324731
confirm_change_worker_address 6233869
get_peer_id 6518998
get_multiaddresses 7043316
change_worker_address 8915609
is_controlling_address 6505135
get_sector_size 5796009
change_multiaddresses 8029671
change_peer_id 7605795
withdraw_balance 8444077

Datacap actor

Function Gas
name 5701200
symbol 5454636
total_supply 7467393
balance 6689611
allowance 7826902
transfer 17419883
transfer_from 25138529
burn 10912697
burn_from 18069780
allowance 11114753
increase_allowance 13829809
decrease_allowance 13821842
revoke_allowance 12377579

Init actor

Function Gas
exec 19750022
exec4 6769021

Market actor

Function Gas
publish_storage_deals 49372504
add_balance 7601580
withdraw_balance 10383734
get_balance 11791187
get_deal_data_commitment 10851148
get_deal_client 6137863
get_deal_provider 6137915
get_deal_label 10948619
get_deal_term 6780985
get_deal_total_price 8220975
get_deal_client_collateral 8039782
get_deal_provider_collateral 8035302
get_deal_verified 6058021
get_deal_activation 6814769

Power actor

Function Gas
miner_count 4791344
network_raw_power 5231774
miner_raw_power 6740644
miner_consensus_count 4805448

Precompiles actor

Function Gas
resolve_address 2512561
lookup_delegated_address (empty response) 2335624
lookup_delegated_address (address found) 2422628
resolve_eth_address 2446047

Send actor

Function Gas
send (actor id) 3277438
send (address) 3591742

Verifreg actor

Function Gas
add_verified_client 13285796
get_claims 10045653
extend_claim_term 11443457
remove_expired_allocations 12981849
remove_expired_claims 11443457

@rllola rllola merged commit 224b591 into master Feb 27, 2023
@rllola rllola deleted the feat/leb-128 branch February 27, 2023 14:17
longfeiWan9 pushed a commit to longfeiWan9/filecoin-solidity that referenced this pull request Mar 7, 2023
@rllola @longfeiWan9
feat: add leb128 encoding feature (Zondax#315)
39b12c1 
* feat: add leb128 encoding deature

* added testing for leb128

* 1024 tests for leb128 encodig

* there is only 11 tests files
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce an Address user-defined type
2 participants
@rllola @emmanuelm41