Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

BigInts: return bool to indicate overflows on bigint conversions #335

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

emmanuelm41
Copy link
Member

@emmanuelm41 emmanuelm41 commented Mar 3, 2023

🔗 zboto Link

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25095220
universal_receiver_hook 4818537

Miner actor

Function Gas
change_owner_address 7434237
get_beneficiary 9802571
change_beneficiary 8733626
get_owner 7411443
get_available_balance 5884848
get_vesting_funds 6089540
repay_debt 6328478
confirm_change_worker_address 6237616
get_peer_id 6522744
get_multiaddresses 7047063
change_worker_address 8919355
is_controlling_address 6508881
get_sector_size 5799755
change_multiaddresses 8033418
change_peer_id 7609541
withdraw_balance 8447824

Datacap actor

Function Gas
name 5700372
symbol 5453808
total_supply 7466565
balance 6688783
allowance 7826074
transfer 17419055
transfer_from 25137701
burn 10911869
burn_from 18068952
allowance 11113925
increase_allowance 13828981
decrease_allowance 13821014
revoke_allowance 12376751

Init actor

Function Gas
exec 19749730
exec4 6768729

Market actor

Function Gas
publish_storage_deals 49703858
add_balance 7643110
withdraw_balance 10425355
get_balance 11825556
get_deal_data_commitment 10896233
get_deal_client 6182941
get_deal_provider 6179445
get_deal_label 10993705
get_deal_term 6811854
get_deal_total_price 8266061
get_deal_client_collateral 8081311
get_deal_provider_collateral 8076831
get_deal_verified 6099551
get_deal_activation 6856298

Power actor

Function Gas
miner_count 4792492
network_raw_power 5232922
miner_raw_power 6741792
miner_consensus_count 4806596

Precompiles actor

Function Gas
resolve_address 2512749
lookup_delegated_address (empty response) 2335812
lookup_delegated_address (address found) 2422816
resolve_eth_address 2446235

Send actor

Function Gas
send (actor id) 3276586
send (address) 3590890

Verifreg actor

Function Gas
add_verified_client 13285796
get_claims 10045653
extend_claim_term 11443457
remove_expired_allocations 12981849
remove_expired_claims 11443457

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Gas results 🚀📝

Account actor

Function Gas
authenticate_message 25095220
universal_receiver_hook 4818537

Miner actor

Function Gas
change_owner_address 7434237
get_beneficiary 9802571
change_beneficiary 8733626
get_owner 7411443
get_available_balance 5884848
get_vesting_funds 6089540
repay_debt 6328478
confirm_change_worker_address 6237616
get_peer_id 6522744
get_multiaddresses 7047063
change_worker_address 8919355
is_controlling_address 6508881
get_sector_size 5799755
change_multiaddresses 8033418
change_peer_id 7609541
withdraw_balance 8447824

Datacap actor

Function Gas
name 5700372
symbol 5453808
total_supply 7466565
balance 6688783
allowance 7826074
transfer 17419055
transfer_from 25137701
burn 10911869
burn_from 18068952
allowance 11113925
increase_allowance 13828981
decrease_allowance 13821014
revoke_allowance 12376751

Init actor

Function Gas
exec 19749730
exec4 6768729

Market actor

Function Gas
publish_storage_deals 49703858
add_balance 7643110
withdraw_balance 10425355
get_balance 11825556
get_deal_data_commitment 10896233
get_deal_client 6182941
get_deal_provider 6179445
get_deal_label 10993705
get_deal_term 6811854
get_deal_total_price 8266061
get_deal_client_collateral 8081311
get_deal_provider_collateral 8076831
get_deal_verified 6099551
get_deal_activation 6856298

Power actor

Function Gas
miner_count 4792492
network_raw_power 5232922
miner_raw_power 6741792
miner_consensus_count 4806596

Precompiles actor

Function Gas
resolve_address 2512749
lookup_delegated_address (empty response) 2335812
lookup_delegated_address (address found) 2422816
resolve_eth_address 2446235

Send actor

Function Gas
send (actor id) 3276586
send (address) 3590890

Verifreg actor

Function Gas
add_verified_client 13285796
get_claims 10045653
extend_claim_term 11443457
remove_expired_allocations 12981849
remove_expired_claims 11443457

@emmanuelm41 emmanuelm41 merged commit efdb3fa into master Mar 3, 2023
@emmanuelm41 emmanuelm41 deleted the feat/bigint-improv branch March 3, 2023 19:43
longfeiWan9 pushed a commit to longfeiWan9/filecoin-solidity that referenced this pull request Mar 7, 2023
…dax#335)

* make functions to return bool value instead of error
* remove unused error
* feat: simplify tests
* fix: bigint tests
* feat: add cases to check overflow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant