Fix cacheSetsMetric (#119)

* Fix cacheSetsMetric * test
Zondax · Apr 19, 2024 · bae8b56 · bae8b56
1 parent 442f07c
commit bae8b56
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/zrouter/zmiddlewares/cache.go b/pkg/zrouter/zmiddlewares/cache.go
@@ -116,7 +116,7 @@ func cacheResponseIfNeeded(rw *responseWriter, r *http.Request, cache zcache.ZCa
 		return
 	}
 
-	if err := metricServer.IncrementMetric(cacheSetsMetric, GetRoutePattern(r)); err != nil {
+	if err := metricServer.IncrementMetric(cacheSetsMetric, GetSubRoutePattern(r), GetRoutePattern(r)); err != nil {
 		logger.GetLoggerFromContext(r.Context()).Errorf("Error incrementing cache_sets metric: %v", err)
 	}
 }

diff --git a/pkg/zrouter/zmiddlewares/zcache_test.go b/pkg/zrouter/zmiddlewares/zcache_test.go
@@ -27,7 +27,9 @@ func TestCacheMiddleware(t *testing.T) {
 		"/cached-path": 5 * time.Minute,
 	}}
 
-	r.Use(CacheMiddleware(metrics.NewTaskMetrics("", "", "appName"), mockCache, cacheConfig))
+	ms := metrics.NewTaskMetrics("", "", "appName")
+	RegisterRequestMetrics(ms)
+	r.Use(CacheMiddleware(ms, mockCache, cacheConfig))
 
 	// Simulate a response that should be cached
 	r.Get("/cached-path", func(w http.ResponseWriter, r *http.Request) {