-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure retry mechanism #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By setting the backoff this way, we disrupt the httpClient interface as well as the mocks used for testing. We could consider adopting a backoff strategy similar to the one used in Resty (following the builder pattern): https://github.com/go-resty/resty?tab=readme-ov-file#retries. Doing so would align our HTTP client with a standard, making it more intuitive and testable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach. Let's wait for Lucas approval, but it is ok for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 馃挭
ClickUp: https://app.clickup.com/t/86942wrhv
馃敆 zboto Link