Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First approach of top n requests metric #80

Merged
merged 14 commits into from
Mar 21, 2024
Merged

First approach of top n requests metric #80

merged 14 commits into from
Mar 21, 2024

Conversation

lucaslopezf
Copy link
Contributor

@lucaslopezf lucaslopezf commented Mar 4, 2024 •
edited by zboto bot

馃敆 zboto Link

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 4, 2024
View reviewed changes
pkg/zcache/redis_cache.go Dismissed Show dismissed Hide dismissed
pkg/zcache/redis_cache.go Dismissed Show dismissed Hide dismissed
@lucaslopezf lucaslopezf marked this pull request as ready for review March 17, 2024 01:03
emmanuelm41
emmanuelm41 requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. But great work!

pkg/zrouter/zrouter.go Outdated Show resolved Hide resolved
pkg/zrouter/zrouter.go Outdated Show resolved Hide resolved
pkg/zrouter/zmiddlewares/topNRequests.go Outdated Show resolved Hide resolved
pkg/zrouter/zmiddlewares/topNRequests.go Outdated Show resolved Hide resolved
pkg/zrouter/zmiddlewares/topNRequests.go Outdated Show resolved Hide resolved
emmanuelm41
emmanuelm41 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see, errors on this new middleware related to redis would not be propagated making the request fail, so it is ready to go!

@lucaslopezf lucaslopezf merged commit 3d584ce into main Mar 21, 2024
4 checks passed
@lucaslopezf lucaslopezf deleted the feat/top-requests-middleware branch March 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucaslopezf @CLAassistant @emmanuelm41