Parser #1
Merged
Parser #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleni
requested changes
Jun 18, 2020
|
Awesome work!! |
|
I noticed it is not compiling because the zbuffer.* files are missing. I have already included in the dev branch. I will rebase this PR so they are included. |
|
The issues for discussion/more info should be labeled with "ExternalDep" so we can flag the Blockstack team. |
|
The project parser is now implemented in Rust, so the CMakefile based tests are probably not applicable in this case. |
…memory alignment, removed some unused code
jleni
reviewed
Jun 19, 2020
This was referenced Jun 19, 2020
Removed the return value of zb_check_canary, and exported this function to the public ffi interface for Rust A clippy configuration file for future settings
…d be added later as features, but we keep their definition
|
CI is now almost ready, the only issue is the zemu/sign test where we still have "1234" |
|
Merging and opening #5 to track pending fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP parser for Blockstack transactions for ledger. It includes some test for spending conditions, post-conditions and token-transfer payloads. Other tests are going to be added soon as issues, along with other improvements and features according to the given requirements.