New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for mainnet/testnet address on any derivation #55
Conversation
Tests fail because of snapshoots, although values are equal. |
To this point, if you're only using the types exposed, I believe you can use TypeScript's |
… getAddress and showAddress signatures for a new address version param
It is ready. now the getAddress/showAddress takes in a new AddressVersion parameter. |
The device is able to process requests for setting the network version to use when calculating the address from the device's pk.
I added a new method to the BlockstackApp object:
setNetworkVersion(path: string, version: number)
Although path is not used, It may be required later.
version is a number that must be either:
or
the default value is Mainnet.
I noticed that the package stacks.js is not part of the dependencies for the js lib, I am not sure if it is intentional. We may include that package in order to use this enum instead of plain number( the internal implementation checks that the version value is correct if not it returns an invalid data error).