disable save button when nothing slected. fixes #1322

[knight-of-ni]

Fixes #1322 on my machine. Please test.

[connortechnology]

Um.. what is element.selected? This is not standard DOM as far as I know. Is it a jquery thing?

Seems to me it should be element.selectedIndex and we should be able to test for >= 0 (-1 means no selection).

[knight-of-ni]

I'm just winging this php stuff.

I noticed that the selected property was being set for each monitor here:
https://github.com/ZoneMinder/ZoneMinder/blob/master/web/skins/classic/views/group.php#L70

I'm not entirely sure that "if" condition even needs to be in there. I left it in there because it seemed to work on my demo system.

[connortechnology]

Oh... the option element has a selected property... but not the select element.
if ( element.selectedIndex >= 0 ) {

can you try that and see if it works?

[knight-of-ni]

sure. give me a sec.

[knight-of-ni]

Ah no, that does not work. The button never enables when I use if ( element.selectedIndex >= 0 ) or even if ( element.selectedIndex )

What does work, is removing that if condition altogether.

[knight-of-ni]

The behaviour we are looking for seems to be similar to this:
https://github.com/ZoneMinder/ZoneMinder/blob/master/web/skins/classic/views/js/monitorpreset.js#L10

Since that is not checking element.selectedIndex , I'll just go ahead and remove the the if condition.

[connortechnology]

Yeah, after reading modern DOM docs... select.value should work just fine.