-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tabs to spaces #1666
tabs to spaces #1666
Conversation
I think a criteria for this getting merged is that the number of changes (additions and deletions) stays equal; that'll help us to clearly see that this PR was only for what it should be. |
I don't see why the # of lines would change. I think git is just being stupid. |
yeah something must have gone wrong. let me fix it. |
So git diff -w master shows no changes.... |
Oh hey, # of changes is the same.... let's merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ConfigData.pm.in (can't inline as file is too large) there are some lines like this:
+ boolean => {
+ db_type =>"boolean",
+ hint =>"yes|no",
+ pattern =>qr|^([yn])|i,
+ check =>q( $1 ),
+ format =>q( ($1 =~ /^y/)
+ ? "yes"
+ : "no"
+ )
+ },
which don't match up with these:
+ integer => {
+ db_type =>"integer",
+ hint =>"integer",
+ pattern =>qr|^(\d+)$|,
+ format =>q( $1 )
+ },
Didn't catch anything else obvious but man, lots-o-changes.
I'm so confused now which branch is which, but I think I've got it cleaned up. I don't want to do any more changes at this time because it is already too big to view here. |
The ongoing work to fix the whitespace/google code style