-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alarm reference image blend percentage option and replace the text field if fast blends are enabled #241
Conversation
…asts) and a dropdown list is used now if ZM_FAST_IMAGE_BLENDS is enabled
… per monitor now)
…erence image blend
Any objections? |
Add alarm reference image blend percentage option and replace the text field if fast blends are enabled
Heads up. This pull request creates an issue with the recently released zoneminder 1.26.5. zmupdate doesn't have the SQL code necessary to make the change in this pull request seamless for normal users. Users will need to be warned they will have to update their Monitors table manually by using the ALTER table command shown above. |
Are you sure? iconnor told me it searches for the update files automatically since v1.26 |
I think so. After building & installing the new rpm on my demo box, I ran sudo zmupdate.pl. It detected a 1.26.4 dB and upgraded it to 1.26.5. After starting zoneminder, my logs filled with errors about the missing column. Manually adding the column fixed it. Can you try on your end? I'll double check on my end as well. |
Found the problem. Makefile.am needs to be updated for the new zm_update-1.26.5.sql file. I have not tried cmake just autotools. Update: found a way to glob all the sql files automatically like cmake does so we don't run into this again. See pull request #269 |
Only when I get home. I think it's not a good idea to update the version number and release right away. We need a day or two to spot upgrade issues after upping the version number. |
Linking to pull request #269 |
In order to improve ZoneMinder's already great motion detection system, i find it necessary to have the ability to use a different reference image blend percent for an alarm state.
This pull request adds such option, as can be seen in the screenshot below.
This option is very useful for controlling how long an alarm lasts. For example, If i set it to not blend and stand in front of my camera, the alarm will last forever, until i move out of the camera's way. If i try again, this time with 50%, the alarm will last only a moment. I have chosen 3.125% as a default because it seems optimal according to my tests.
If anyone is looking for the behaviour of ZM without this option, simply set it identical to your non-alarm reference blend percent.
Something else this pull request does is replace the text field with a dropdown list if fast blends are enabled. Fast blend does not use division, but rather bit shifting, so only few values are possible and other values simply get rounded to the closest one. By using a dropdown list when fast blends are enabled, we make it easier for the user to select a reference image blend percent.
Currently, i am missing the code to alter the database to add the new field. Not sure how to tackle this one yet. I thought of creating a zm_update-1.26.4 file for ZM 1.26.5, but this will require us to change version numbers now to 1.26.5.
The SQL statement to alter the Monitors table: