Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object Injection in onvifprobe.php #2272

Closed
prodigysml opened this issue Oct 24, 2018 · 1 comment
Closed

Object Injection in onvifprobe.php #2272

prodigysml opened this issue Oct 24, 2018 · 1 comment

Comments

@prodigysml
Copy link

The Issue

Command injection is an attack which uses overly trusting user-controlled input, when performing operating system commands from within the application. This allows an attacker to perform unauthorised operating system commands on the target server.

Where the Issue Occurred:

zoneminder/web/skins/classic/views/onvifprobe.php

Line 216 in 18850d8

$probe = unserialize(base64_decode($_REQUEST['probe']));

Remediation

https://www.owasp.org/index.php/OS_Command_Injection_Defense_Cheat_Sheet
connortechnology pushed a commit to connortechnology/ZoneMinder that referenced this issue Oct 24, 2018
use json_encode/decode instead of serialize/unserialize to pass onvif…
2024df4 
… probe results around. Also clean up some code/ add some missing things. Fixes ZoneMinder#2271 and ZoneMinder#2272
@connortechnology connortechnology mentioned this issue Oct 24, 2018
Merged
@prodigysml prodigysml changed the title Command Injection in onvifprobe.php Object Injection in onvifprobe.php Oct 28, 2018
@knight-of-ni
Copy link
Member

knight-of-ni commented Oct 30, 2018 •
edited

fixed via #2273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knight-of-ni @prodigysml