Merge pull request #1014 from ZopaPublic/fix-icon-error

fix(icon): pass a string rather than undefined to the font awesome co…
ZopaPublic · May 17, 2024 · 277b86d · 277b86d
2 parents 391bc5f + f4de3e8
commit 277b86d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/fuzzy-poets-carry.md b/.changeset/fuzzy-poets-carry.md
@@ -0,0 +1,5 @@
+---
+'@zopauk/react-components': patch
+---
+
+fix icon component passing undefined classname to font awesome
diff --git a/src/components/atoms/Icon/Icon.tsx b/src/components/atoms/Icon/Icon.tsx
@@ -22,12 +22,12 @@ export const RoundBadge = styled.div<{ color: Colors[keyof Colors] }>`
   padding: ${spacing[6]};
 `;
 
-export default function Icon({ variant, bgColor, ariaLabel, className, ...rest }: IconProps) {
+export default function Icon({ variant, bgColor, ariaLabel, className = '', ...rest }: IconProps) {
   const renderIcon = (className?: string) => (
     <FontAwesomeIcon
       {...rest}
       icon={variant}
-      className={className}
+      className={className || ''}
       aria-label={ariaLabel}
       aria-hidden={ariaLabel ? false : true}
     />