Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression tests #14

Open
ubbe-xyz opened this issue May 27, 2019 · 1 comment
Open

Visual regression tests #14

ubbe-xyz opened this issue May 27, 2019 · 1 comment
Assignees
Labels
enhancement For discussing possible improvements

Comments

@ubbe-xyz
Copy link
Contributor

Following #13, we concluded it's worth adding visual regression test to this library as well as testing behavior in an actual browser so that we can refactor and update features with an extra level of confidence.

Cypress seems a good candidate for tooling, we already use it extensively in some products at Zopa and we're quite happy with its features and developer experience.

Any other suggestions welcome ❤

@ubbe-xyz ubbe-xyz added the chore Work that doesn't fix an issue nor brings a new feature label May 27, 2019
@ubbe-xyz ubbe-xyz self-assigned this May 27, 2019
@poteirard
Copy link
Contributor

poteirard commented May 31, 2019

Also, investigate if we could use https://github.com/styleguidist/snapguidist for this

Edit: Snapguidist doesn't support styled-components and CI

@ubbe-xyz ubbe-xyz changed the title Visual regression tests 👁‍🗨 Visual regression tests Oct 9, 2019
@ubbe-xyz ubbe-xyz added the help wanted Extra attention is needed label Oct 28, 2019
@ubbe-xyz ubbe-xyz added enhancement For discussing possible improvements and removed chore Work that doesn't fix an issue nor brings a new feature help wanted Extra attention is needed labels Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For discussing possible improvements
Projects
None yet
Development

No branches or pull requests

2 participants