fix(flexcol): change align default prop #39
Merged
+38
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poteirard
requested review from
AntonyKwok,
JuliaHempel,
ubbe-xyz,
steedems and
thegrinder
as code owners
thegrinder
approved these changes
Jun 21, 2019
poteirard
force-pushed
the
change_default_flexcol
branch
from
9d40717
to
d9c62f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 63 63
Lines 527 527
Branches 120 120
=======================================
Hits 452 452
Misses 75 75
Continue to review full report at Codecov.
|
poteirard
pushed a commit
that referenced
this pull request
Jun 21, 2019
## [1.1.3](v1.1.2...v1.1.3) (2019-06-21) ### Bug Fixes * **flexcol:** change align default prop ([#39](#39)) ([a3b5b68](a3b5b68))
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @thegrinder for finding this bug.
Basically if we set up an alignment in the parent component of
<FlexCol />this one get replaces as we are settingalign-self: flex-start.Now we set 'auto' as a default