Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan Test: Fix a case where replay would fail if the application specified VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT and the compile was skipped at capture time due to a duplicate PSO. #79

Open
Zorro666 opened this issue Jul 5, 2022 · 0 comments
Open

Vulkan Test: Fix a case where replay would fail if the application specified VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT and the compile was skipped at capture time due to a duplicate PSO. #79

Zorro666 opened this issue Jul 5, 2022 · 0 comments
Assignees
@Zorro666
Labels
enhancement

Comments

@Zorro666
Copy link
Owner

Zorro666 commented Jul 5, 2022

657257d Vulkan: Fix a case where replay would fail if the application specified VK_PIPELINE_CREATE_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT_EXT and the compile was skipped at capture time due to a duplicate PSO.

probably an (overly) simple one to test 🙂 tl;dr need to create on PSO using a cache, then create an identical PSO using the same cache and that flag, then only reference the second PSO so only it gets included in the capture
@Zorro666 Zorro666 self-assigned this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zorro666 Zorro666

Labels
enhancement
Projects
RenderDoc Metal
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zorro666