Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Cop warnings #5

Closed
xeron opened this issue Apr 9, 2015 · 1 comment
Closed

Deprecation Cop warnings #5

xeron opened this issue Apr 9, 2015 · 1 comment

Comments

@xeron
Copy link

xeron commented Apr 9, 2015

open-recent (2 deprecations):
Call ::getActiveTextEditor instead
Called 4 times

Workspace.getActiveEditor - /Applications/Atom.app/Contents/Resources/app/src/workspace.js:999:12
[object Object].onUriOpened - /Users/xeron/.atom/packages/open-recent/lib/main.coffee:32:26

Use ::getDirectories instead
Called 1 time

Project.getRootDirectory - /Applications/Atom.app/Contents/Resources/app/src/project.js:593:12
[object Object].insertCurrentPaths - /Users/xeron/.atom/packages/open-recent/lib/main.coffee:136:29

Also open-recent affects atom-core:

atom core (1 deprecation):
Use a config schema instead. See the configuration section of https://atom.io/docs/latest/hacking-atom-package-word-count and https://atom.io/docs/api/latest/Config for more details
Called 1 time

Package.activateConfig - /Applications/Atom.app/Contents/Resources/app/src/package.js:250:11
Package.activateNow - /Applications/Atom.app/Contents/Resources/app/src/package.js:221:14

Related to atom/atom#6310, disabling open-recent removes this warning.

@Zren
Copy link
Owner

Zren commented Apr 9, 2015

To non sleepy self:

  1. Simple rename
  2. getDirectories().length
  3. Change configDefaults to config and do { type: 'number', default: 123 } instead.

@Zren Zren closed this as completed in c77be71 Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants