Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

After updating to Atom 0.190.0 I get following deprecation notification of Atom core #6310

Closed
rukshn opened this issue Apr 8, 2015 · 17 comments

Comments

@rukshn
Copy link

rukshn commented Apr 8, 2015

After updating to Atom 0.190.0 I get the following 3 deprecation notices of Atom core. Anyone else noticed this?

Use a config schema instead. See the configuration section of https://atom.io/docs/latest/hacking-atom-package-word-count and https://atom.io/docs/api/latest/Config for more details
Called 1 time
Package.activateConfig - /usr/share/atom/resources/app/src/package.js:250:11
Package.activateNow - /usr/share/atom/resources/app/src/package.js:221:14


Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows:

"activationCommands": {
"atom-workspace": ["foo:bar", "foo:baz"],
"atom-text-editor": ["foo:quux"]
}
Called 1 time
Package.getActivationCommands - /usr/share/atom/resources/app/src/package.js:764:9
Package.hasActivationCommands - /usr/share/atom/resources/app/src/package.js:689:20


ContextMenuManager::add has changed to take a single object as its argument. Please see https://atom.io/docs/api/latest/ContextMenuManager for more info.
Called 1 time
ContextMenuManager.add - /usr/share/atom/resources/app/src/context-menu-manager.js:57:18
Package.activateResources - /usr/share/atom/resources/app/src/package.js:299:61

@izuzak
Copy link
Contributor

izuzak commented Apr 8, 2015

This looks very similar to #6278. @kevinsawicki -- #6278 turned out to be a problem in two packages. Would it be possible to somehow not report these as Atom core problems, but rather package problems?

@rukshn
Copy link
Author

rukshn commented Apr 9, 2015

@izuzak, yes #6278 does look similar, but I've not installed the packages that caused the problem in that error, and even when I disabled the 3rd party packages the error is still there.

It's shown as deprecation notices for atom core, doesn't show as a problem with any packages. That's why reported it as an atom core problem because I couldn't find any packages that's causing the problem. It might be a problem in one of the core packages

@ghost
Copy link

ghost commented Apr 9, 2015

+1

@mnquintana
Copy link
Contributor

@rukshn Have you tried starting Atom in safe mode (atom --safe)? I see the same deprecation warnings normally, but not in safe mode, which makes me think it's actually some user installed package(s) that's causing this, despite the deprecation warning text.

@rukshn
Copy link
Author

rukshn commented Apr 11, 2015

@mnquintana Hi, yes the warnings are there in the safe mode also when i tried atom in safe mode.

@rabugento
Copy link

In my tests, this error shows when installs "linter" and "linter-jshint" packages.
I compile atom with these packages included.

Anyone knows how to fix this error?

@mark-hahn
Copy link
Contributor

You should post issues on the repos for those packages.

On Sat, Apr 11, 2015 at 7:20 PM, rabugento notifications@github.com wrote:

In my tests, this errors shows when installs "linter" and "linter-jshint"
packages.
I compile atom with these packages included.

Anyone knows how to fix this error?


Reply to this email directly or view it on GitHub
#6310 (comment).

@rabugento
Copy link

mark-hahn, I'll do this. Thanks.

@ttaranto
Copy link

+1

@idan
Copy link

idan commented Apr 20, 2015

Seeing the same deprecation warnings in 0.192, with slightly different line numbers:

deprecation_cop_-_users_igazit_dropbox__personal__heroku_awsdetailedbilling-_atom

Also seeing a warning about using a configSchema in package.activateConfig.

Unlike OP, both of these warnings go away when I load with --safe. Going through my addons and trying to isolate which one is responsible.

@idan
Copy link

idan commented Apr 20, 2015

OK, it is caused by 3rd party packages:

  • sublime-style-column-selection triggers the first deprecation error
  • emmet triggers the second

Filing tickets on each.

@idan
Copy link

idan commented Apr 20, 2015

@mnquintana
Copy link
Contributor

@izuzak Is this one resolved now with the recent changes in Grim?

@izuzak
Copy link
Contributor

izuzak commented Apr 27, 2015

@izuzak Is this one resolved now with the recent changes in Grim?

Not yet. There are a few different deprecations here that needed tweaking, and we've been fixing them one-by-one. For example, this isn't fixed/merge yet: #6522. After that's fixed, I plan on going through this issue one more time to make sure we didn't miss anything. I'll close the issue once that's done.

@izuzak
Copy link
Contributor

izuzak commented Apr 28, 2015

Thanks for all the reports, everyone! ✨ The way deprecated calls were being detected and reported needed some tweaking for specific calls. We've been doing that over the last week and I think we've handled all the incorrect attributions mentioned in this issue (e.g. see #6510, #6522, atom/grim#5).

These changes will be shipped with the next release of Atom (or right now if you're building from source). If you notice any other incorrect attributions in Deprecation Cop in Atom 0.195.0 (when it's released) -- please open a new issue here, or even better at https://github.com/atom/deprecation-cop. 🙇

@izuzak izuzak closed this as completed Apr 28, 2015
@lgomez
Copy link

lgomez commented Apr 30, 2015

+1 Just reporting that the warning goes away when disabling https://atom.io/packages/atom-alignment @Freyskeyd

@lock
Copy link

lock bot commented Jan 22, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants