Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctrl+Return shortcut to mark item as complete #117

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Add ctrl+Return shortcut to mark item as complete #117

merged 1 commit into from
Nov 20, 2017

Conversation

mcorteel
Copy link
Contributor

This is really missing. I'm not sure if my PR actually works, but I guess that the change should look something like that.

This is really missing. I'm not sure if my PR actually works, but I guess that the change should look something like that.
@Zren
Copy link
Owner

Zren commented Nov 15, 2017

Is this a standard shortcut for something else? It's not a shortcut in Google Tasks.

@mcorteel
Copy link
Contributor Author

I don't know if it's standard or if that's the particular shortcut that should be set, but IMO there should really be a shortcut to mark an item as completed (it may also switch the completed status).
Google Tasks uses alt+Return.

@Zren Zren merged commit bc047f8 into Zren:master Nov 20, 2017
@Zren
Copy link
Owner

Zren commented Nov 20, 2017

I'll add a || "alt+Return" conditional after the merge so it's familiar with google task users too. That should hold them off till I figure out a way to make configurable shortcuts.

@Zren
Copy link
Owner

Zren commented Nov 21, 2017

Also made it toggle instead of just setting complete=true.

@mcorteel
Copy link
Contributor Author

That's awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants