Private message goes to the wrong player

[x1p]

Description of issue or feature request:
Replying sometimes goes to the wrong person.

---

DELETE THIS SECTION IF YOU ARE SUBMITTING A FEATURE REQUEST

ERROR (DELETE IF YOU HAVE NO ERROR):
Fictive scenario to clearify

playerabc executes /msg player123 Testing 123
  Player123 -> player123: Testing 123
playerabc executes /r Another test
  Player123 -> playermessagedbefore: Another test
playerabc executes /msg playermessagedbefore Sorry, wasn't for you
  Player123 -> playermessagedbefore: Sorry, wasn't for you

CONFIG SECTION (DELETE IF NOT RELEVANT):

  # When set to false, each time you will use /r you will reply to person you previously sent message directly or to person who sent you message if there is none you have conversion before
  # When this set to true, players with /r will reply to person who last sent private message. This can result in confusion when using /r while getting private messages from multiple players
  ReplyToLastMessenger: true

---

Cmi Version (using/cmi version):
CMI8.0.21.4 but this bug is present for a while.

Server Type (Spigot/Paperspigot/etc):
Paperspigot

Server Version (using /ver):
1.13.2

[LogGits]

I think thats was written wrong in the config. When you set ReplyToLastMessenger: false does this function in the way that you need?

[x1p]

That would be an option in the case, described above.
But, if set false then you would not be able to reply if someone sends you a message.
Example:
PlayerOther: /msg PlayerYou Hey!
PlayerYou: /r Hi!
This last message would go to someone way back, when you did explicitly /msg PlayerSomeone

Both methods are not consistent.

[LogGits]

Ah ok thanks. So just to confirm:

1. when set to false, it should only allow you to respond to people who message you.
2. when set to true, it should only allow you to respond to people that you message.

When you test those, is that how its functioning? (if not i will label this a bug report)

[x1p]

Imho from what I notice:
when false (default) it responds to people who you have explicitly messaged before.
when true it responds to people you just messaged you (even if you may have not messaged before)

False works normal from what I can tell. Only people on my server do not want that.
True works most of the time, but sometimes won't repond to the right person, even when you have explicitly messaged him before.

Essentials has this setting also.

# Changes /reply functionality. If true, /r goes to the person you messaged last, otherwise the first person that messaged you. 
# If false, /r goes to the last person that messaged you. (default=false)
last-message-reply-recipient: true

# If last-message-reply-recipient is true, this specifies the duration, in seconds, that would need to elapse for the 
# reply-recipient to update when receiving a message.
# Default is 180 (3 minutes)
last-message-reply-recipient-timeout: 180

[mrfloris]

Can confirm, we have this issue as well. I have /chat someone, for a perm chat, someone else does /r and they tell me it's the wrong person who gets it. I sometimes get msgs from players who in console clearly show to /msg someone first, then msg, they get a reply from /msg from someone else, and /r to them, but i get the msg.

[LogGits]

Ok I'm not really following. Essentials method being set to true is CMI's method being set to false.

@mrfloris what is your ReplyToLastMessenger setting set to?

Also, if it's still an issue it would be convenient someone could provide a better use case. We tested the provided method and it works as intended.

False, sets the reply recipient to the last person u messaged.
True, sets the reply recipient to the last person to message you.
When this was set to False this was the result:

a /msg c
b /msg a
a /r  <- goes to c

[Zrips]

Will add option to define timeout for responder, this should some the issue.