Fix packet handling issues in multiplayer causing players to disconnect

ZsoltMolnarrr · Oct 28, 2023 · 15bf9fb · 15bf9fb
1 parent ec989ab
commit 15bf9fb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 1.8.1
+
+- (1.20.2) Fix packet handling issues in multiplayer causing players to disconnect.
+
 # 1.8.0
 
 New features:

diff --git a/common/src/main/java/net/bettercombat/utils/SoundHelper.java b/common/src/main/java/net/bettercombat/utils/SoundHelper.java
@@ -35,8 +35,7 @@ public static void playSound(ServerWorld world, Entity entity, WeaponAttributes.
                     sound.id(),
                     sound.volume(),
                     pitch,
-                    rng.nextLong())
-                    .write();
+                    rng.nextLong());
 
             var soundEvent = Registries.SOUND_EVENT.get(new Identifier(sound.id()));
             var distance = soundEvent.getDistanceToTravel(sound.volume());
@@ -45,7 +44,7 @@ public static void playSound(ServerWorld world, Entity entity, WeaponAttributes.
                 var channel = Packets.AttackSound.ID;
                 try {
                     if (ServerPlayNetworking.canSend(serverPlayer, channel)) {
-                        ServerPlayNetworking.send(serverPlayer, channel, packet);
+                        ServerPlayNetworking.send(serverPlayer, channel, packet.write());
                     }
                 } catch (Exception e){
                     e.printStackTrace();

diff --git a/gradle.properties b/gradle.properties
@@ -10,12 +10,12 @@ minecraft_version=1.20.2
 yarn_mappings=1.20.2+build.1
 
 # Loader
-fabric_version=0.89.2+1.20.2
+fabric_version=0.90.4+1.20.2
 loader_version=0.14.22
 forge_version=48.0.4
 
 # Mod Properties
-mod_version=1.8.0
+mod_version=1.8.1
 maven_group=net
 archives_base_name=bettercombat