Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G4mespeed mod #10

Closed
ardissaps opened this issue Jul 21, 2022 · 7 comments
Closed

G4mespeed mod #10

ardissaps opened this issue Jul 21, 2022 · 7 comments
Labels
incompatibility Gotta have a little sadness once in a while so you know when the good times come

Comments

@ardissaps
Copy link

https://paste.atlauncher.com/view/3dfd2c89-d0f5-48ef-b7f1-de23f095c465
@chronosacaria
Copy link
Contributor

I might be missing something, but I think I see what is going on here, so I figured I'd throw this in here:

This issue appears to be coming from G4mespeed conflicting with BetterCombat as per this part of your log (it has been mapped to make it easier to read):

[21/07/2022 07:30:56 AM] [Render thread/WARN] Configuration conflict: there is more than one oshi.architecture.properties file on the classpath
[21/07/2022 07:30:56 AM] ---- Minecraft Crash Report ----
[21/07/2022 07:30:56 AM] // You should try our sister game, Minceraft!
[21/07/2022 07:30:56 AM] 
[21/07/2022 07:30:56 AM] Time: 7/21/22, 7:30 AM
[21/07/2022 07:30:56 AM] Description: Initializing game
[21/07/2022 07:30:56 AM] 
[21/07/2022 07:30:56 AM] java.lang.RuntimeException: Mixin transformation of net.minecraft.client.render.WorldRenderer failed
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:419)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
[21/07/2022 07:30:56 AM] 	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
[21/07/2022 07:30:56 AM] 	at net.minecraft.client.MinecraftClient.<init>(MinecraftClient.java:573)
[21/07/2022 07:30:56 AM] 	at net.minecraft.client.main.Main.main(Main.java:197)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[21/07/2022 07:30:56 AM] Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:414)
[21/07/2022 07:30:56 AM] 	... 9 more
[21/07/2022 07:30:56 AM] Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [g4mespeed.mixins.json:client.GSWorldRendererMixin from mod g4mespeed] from phase [DEFAULT] in config [g4mespeed.mixins.json] FAILED during APPLY
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinApplyError(MixinProcessor.java:589)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:379)
[21/07/2022 07:30:56 AM] 	... 12 more
[21/07/2022 07:30:56 AM] Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Specified index 4 for @ModifyArg is invalid for args (Lnet/minecraft/WorldRenderer;Lnet/minecraft/Entity;DDDFLnet/minecraft/MatrixStack;Lnet/minecraft/VertexConsumerProvider;), expected F on net/minecraft/WorldRenderer::onRenderEntityModifyDeltaTick [INJECT Applicator Phase -> g4mespeed.mixins.json:client.GSWorldRendererMixin from mod g4mespeed -> Apply Injections ->  -> Inject -> g4mespeed.mixins.json:client.GSWorldRendererMixin from mod g4mespeed->@ModifyArg::onRenderEntityModifyDeltaTick(Lnet/minecraft/Entity;DDDFLnet/minecraft/MatrixStack;Lnet/minecraft/VertexConsumerProvider;)F]
[21/07/2022 07:30:56 AM] 	at Not Enough Crashes deobfuscated stack trace.(1.18.2+build.3)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.findArgIndex(ModifyArgInjector.java:158)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.injectAtInvoke(ModifyArgInjector.java:113)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.injection.invoke.InvokeInjector.inject(InvokeInjector.java:82)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.inject(ModifyArgInjector.java:103)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.injection.code.Injector.inject(Injector.java:276)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.inject(InjectionInfo.java:445)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1378)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1052)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
[21/07/2022 07:30:56 AM] 	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:414)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
[21/07/2022 07:30:56 AM] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:520)
[21/07/2022 07:30:56 AM] 	at net.minecraft.client.MinecraftClient.<init>(MinecraftClient:573)
[21/07/2022 07:30:56 AM] 	at net.minecraft.client.main.Main.main(Main:197)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
[21/07/2022 07:30:56 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

It looks like that they both are trying to target Lnet/minecraft/client/render/WorldRenderer;renderEntity(Lnet/minecraft/entity/Entity;DDDFLnet/minecraft/client/util/math/MatrixStack;Lnet/minecraft/client/render/VertexConsumerProvider;)V, but one is doing a @Redirect (BetterCombat) and the other is doing, presumably, something similar. Sadly, G4mespeed is All Rights Reserved and isn't Open Source, so I can't see what they're doing without decompiling their mod. I hope that this is somewhat useful

@floral-qua-floral
Copy link

Was able to confirm that this is definitely an incompatibility between Better Combat and G4mespeed. So it might be worth changing the title of the issue to "Crash on startup with g4mespeed mod" or something similar. Here's a crash report where only Fabric API, CompleteConfig, Better Combat, and G4mespeed are loaded:
crash-2022-07-20_18.53.01-client.txt

I'm already in the G4mespeed mod's discord server, so I'll put a message in the support channel there linking to this issue so that that mod's developer can be aware of the incompatibility as well.

@ardissaps
Copy link
Author

I tried disabled g4merspeed today but it still won't launch to the game. Seems like conflict with another mods too?
https://paste.atlauncher.com/view/1ce84704-88b7-49b9-8083-23a495912476

@chronosacaria
Copy link
Contributor

@ardissaps This new issue that you are presenting appears to be between BetterCombat and Custom Crosshair Mod as per this part of your log (again, mapped for ease of reading):

[21/07/2022 09:39:32 AM] [Render thread/WARN] Configuration conflict: there is more than one oshi.architecture.properties file on the classpath
[21/07/2022 09:39:32 AM] ---- Minecraft Crash Report ----
[21/07/2022 09:39:32 AM] // Hi. I'm Minecraft, and I'm a crashaholic.
[21/07/2022 09:39:32 AM] 
[21/07/2022 09:39:32 AM] Time: 7/21/22, 9:39 AM
[21/07/2022 09:39:32 AM] Description: Initializing game
[21/07/2022 09:39:32 AM] 
[21/07/2022 09:39:32 AM] java.lang.RuntimeException: Mixin transformation of net.minecraft.client.gui.hud.InGameHud failed
[21/07/2022 09:39:32 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:419)
[21/07/2022 09:39:32 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
[21/07/2022 09:39:32 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
[21/07/2022 09:39:32 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
[21/07/2022 09:39:32 AM] 	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
[21/07/2022 09:39:32 AM] 	at net.minecraft.client.MinecraftClient.<init>(MinecraftClient.java:593)
[21/07/2022 09:39:32 AM] 	at net.minecraft.client.main.Main.main(Main.java:197)
[21/07/2022 09:39:32 AM] 	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
[21/07/2022 09:39:32 AM] 	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
[21/07/2022 09:39:32 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[21/07/2022 09:39:32 AM] Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
[21/07/2022 09:39:32 AM] 	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:414)
[21/07/2022 09:39:32 AM] 	... 9 more
[21/07/2022 09:39:32 AM] Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector crosshairmod$renderCrosshair(Lnet/minecraft/InGameHud;Lnet/minecraft/MatrixStack;IIIIII)V in crosshairmod.mixins.json:InGameHudMixin from mod crosshairmod failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap crosshairmod-refmap.json
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1385)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1052)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
[21/07/2022 09:39:32 AM] 	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
[21/07/2022 09:39:32 AM] 	... 12 more

It looks like they are both trying to target Lnet/minecraft/InGameHud;Lnet/minecraft/MatrixStack;IIIIII)V; Better Combat via InGameHudInject#pre_renderCrosshair and Custom Crosshair Mod via crosshairmod$renderCrosshair. It also appears that the Custom Crosshair Mod is trying to @Redirect as well, like BetterCombat is.

As Custom Crosshair Mod is, as G4mespeed is, All Rights Reserved and not Open Source, I cannot see what, exactly, is going on. However, it would probably be advisable to make a separate issue concerning this crash as it is related to a different mod. I would suggest a title, something along the lines of: "Crash on startup with Custom Crosshair Mod (v. 0.4.5)". You could also either copy and paste the mapped crash report or just link to this comment to make things easier for yourself

@ZsoltMolnarrr ZsoltMolnarrr changed the title Crash Log G4mespeed incompatibility Jul 21, 2022
@ZsoltMolnarrr ZsoltMolnarrr mentioned this issue Jul 21, 2022
Closed
@ZsoltMolnarrr ZsoltMolnarrr added the incompatibility Gotta have a little sadness once in a while so you know when the good times come label Jul 21, 2022
@ZsoltMolnarrr
Copy link
Owner

Since that mod is not open source, priority for fixing is super low.

ZsoltMolnarrr added a commit that referenced this issue Jul 21, 2022
@ZsoltMolnarrr
Fix first person render issues #5 #10
43249fc
@ZsoltMolnarrr ZsoltMolnarrr changed the title G4mespeed incompatibility G4mespeed mod Jul 21, 2022
@G4me4u
Copy link

G4me4u commented Aug 1, 2022

Hello! I am guessing you already fixed the issue in 4de01e6. I would have to actually check it myself though.

I was on vacation when seeing this issue, so I had no way to resolve it myself.

@ZsoltMolnarrr
Copy link
Owner

Seems to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
incompatibility Gotta have a little sadness once in a while so you know when the good times come
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ZsoltMolnarrr @G4me4u @floral-qua-floral @chronosacaria @ardissaps