Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-person Model API Usage #329

Closed
mpustovoi opened this issue Jan 27, 2024 · 2 comments
Closed

First-person Model API Usage #329

mpustovoi opened this issue Jan 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mpustovoi
Copy link
Contributor

mpustovoi commented Jan 27, 2024

Minecraft version - 1.20.1
Mod loader - Fabric
Mod version - 1.8.3
I am using the latest version available - Yes

Describe the bug
With latest First-person Model mod version (2.3.1-1.20.1 - Fabric) game crashes after trying to hit a mob with any weapon.
Crash-report and latest.log:
https://gist.github.com/mpustovoi/b7bc2ed04ebfe1b93f3fe725946bf384

To Reproduce
Steps to reproduce the behavior:

  1. Install Fabric 1.20.1, Better Combat 1.8.3, First-person Model 2.3.1 (and playerAnimator 1.0.2).
  2. Join a world and hit a mob with any weapon.
  3. Game crashes.

Expected behavior
Expected that the crash wouldn't happen.

Screenshots or video recordings
Crash happens instantly after clicking LMB.

Additional context
The author of the First-person Model mod replied that the problem isn't in his mod.

@mpustovoi
Copy link
Contributor Author

Better Combat will have to update, it's not using the API but instead calling into internals. For the dev version I re-added the field its trying to get as a workaround against the crash.

Originally posted by @tr7zw in tr7zw/FirstPersonModel#417 (comment)

@tr7zw
Copy link
Contributor

tr7zw commented Jan 27, 2024

The version with workaround is now out (2.3.2). (still needs to be fixed, I'll remove the workaround again at some point)

@mpustovoi mpustovoi reopened this Jan 27, 2024
@ZsoltMolnarrr ZsoltMolnarrr changed the title Crash with latest First-person Model First-person Model API Usage Jan 28, 2024
@ZsoltMolnarrr ZsoltMolnarrr added the enhancement New feature or request label Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants