Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] combatroll:count 0 allows one roll #14

Closed
e3valdas opened this issue Oct 30, 2022 · 2 comments
Closed

[Bug report] combatroll:count 0 allows one roll #14

e3valdas opened this issue Oct 30, 2022 · 2 comments

Comments

@e3valdas
Copy link

Minecraft version - 1.19.2
Mod loader - Fabric 0.14.10
Mod version - 1.0.8
I am using the latest version available - yes.

Describe the bug
Setting attribute combatroll:count to 0 is the same as setting it to 1 (default).

To Reproduce
Steps to reproduce the behavior:

  1. Run command /attribute @s combatroll:count base set 0
  2. Attempt to roll.

Expected behavior
Doing this should take away player's ability to roll.

@ZsoltMolnarrr
Copy link
Owner

Interesting find, I will investigate whenever I have time.

@ZsoltMolnarrr
Copy link
Owner

public static final EntityAttribute COUNT = (new ClampedEntityAttribute("attribute.name.combat_roll." + countName, 1, 1, 20.0)).setTracked(true);

(min = 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants