Added example for QT and conan #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QT is moved to a separate CMakePreset, because first time configuring will take a lot of time and only one job is enough to check that.
arnemertz
requested changes
Mar 4, 2024
CMakePresets.json
Outdated
| @@ -12,6 +12,9 @@ | |||
| "hidden": true, | |||
| "binaryDir": "${sourceDir}/out/build/${presetName}", | |||
| "installDir": "${sourceDir}/out/install/${presetName}", | |||
| "environment": { | |||
| "DONT_CONFIGURE_QT": "1" | |||
There was a problem hiding this comment.
what happens in an environment where this variable is not set at all? From what I see that means that's the same as DONT_CONFIGURE_QT=0, i.e. it will be not not configured.
I am not sure whether that should be the default, and double negatives are a pain. Can this be inverted to "CONFIGURE_QT": "0"?
There was a problem hiding this comment.
Yes you are totally right. Resolved this brainf**k :)
arnemertz
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable the build for QT but there are some changes which aren't directly connected to the QT:
Following changes are related to QT (only infrastructure was created)