Header & Footer #22
Header & Footer #22
Conversation
There was a problem hiding this comment.
Hi @ZuhRa-HashiMi
I'm Tadesse Alemayehu your reviewer for this PR. ✋
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request 🛑🛑
You have submitted a project that has linter tests falling. Please make sure all linters are set up and passing before your next review request.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
There was a problem hiding this comment.
Status: Failed ❌
Hi @ZuhRa-HashiMi ,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request 🛑🛑
You have submitted a project that has linter tests falling. Please make sure all linters are set up and passing before your next review request.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
There was a problem hiding this comment.
Hi @ZuhRa-HashiMi ,
Great job so far!
You are almost there, just a couple of simple issues we need to discuss together!
Highlights 💯
No linters errors ✔️
Following Gitflow ✔️
Following HTML, CSS best practices ✔️
Required Changes ♻️
-
Kindly fix the disappearing icon at the top left of the page to make it visible.
-
Kindly rename your branch name from 'master' and give it any name according to the feature you are implementing, like 'header-footer' as an example.
-
Please, Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/index.html
Outdated
| <div class="copyright"> | ||
| <p class="text-sm text-center mt-6 text-gray-500"> | ||
| © 2022. Omar"Faruq" & Zuhra"Hashimi" | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
- Kindly change the footer's inner text as you have to follow the required wireframe:
There was a problem hiding this comment.
Status: Approved 🎉 ✔️
Hi @ZuhRa-HashiMi ,
Your milestone is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
No linter errors. ✔️
Good README file. ✔️
Milestone worked as expected. ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
make the header section
make the footer section