Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an animation when an attack misses #10

Closed
wants to merge 1 commit into from

Conversation

arnaudcoj
Copy link

Now there is a little smoke animation when an attack misses (for the player or the ennemies)
-Added effect_miss1.png in res folder
-Loaded it in ResourceLoader
-Added the effect in VisualEffectCollection
-Changed the size of the preloadedTiles array in TileManager in order to store the effect in it
-Added a method startMissedEffect, called it in executePlayerAttack() and attackWithCurrentMonster()
-Deleted a call to playerAttackCompleted in executePlayerAttack() because it is now called at the end of the miss effect

@Zukero
Copy link
Owner

Zukero commented Jan 22, 2017

This implementation had fundamental issues, and the game's rendering engine had some too.
I included this, thanks to your proposal, during the implementation of the smooth movement and scrolling feature that enhanced the "animation" capabilities of the engine.
Closing the PR, but thanks a lot for your submission. We received great feedback about the addition of the "MISS" animation.

@Zukero Zukero closed this Jan 22, 2017
Zukero pushed a commit that referenced this pull request Nov 6, 2018
sync nutAndor:master from zukero:master
Chriz76 pushed a commit to Chriz76/andors-trail that referenced this pull request Jun 28, 2020
Chriz76 pushed a commit to Chriz76/andors-trail that referenced this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants