Skip to content

Commit

Permalink
More exception details for easier debugging of ImageMagick issues.
Browse files Browse the repository at this point in the history
Especially for Windows.
  • Loading branch information
Julian-O committed Jul 1, 2017
1 parent e50aef7 commit dc4a16a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 15 deletions.
5 changes: 3 additions & 2 deletions moviepy/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ def try_cmd(cmd):
success, err = try_cmd([IMAGEMAGICK_BINARY])
if not success:
raise IOError(
str(err) +
" - The path specified for the ImageMagick binary might be wrong")
"%s - The path specified for the ImageMagick binary might be wrong: %s" %
(err, IMAGEMAGICK_BINARY)
)



Expand Down
15 changes: 2 additions & 13 deletions tests/test_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"""Tool tests meant to be run with pytest. Taken from PR #121 (grimley517)."""
import sys
import time
import pytest

import moviepy.tools as tools
import pytest


def test_ext():
Expand Down Expand Up @@ -69,17 +69,6 @@ def test_5():
file = sys.stdout.read()
assert file == b""

def test_6():
"""Test subprocess_call for operation.
The process sleep should run for a given time in seconds.
This checks that the process has deallocated from the stack on
completion of the called process.
"""
process = tools.subprocess_call(["sleep" , '1'])
time.sleep(1)
assert process is None

if __name__ == '__main__':
pytest.main()
pytest.main()

0 comments on commit dc4a16a

Please sign in to comment.