put DEVNULL into compat.py (#432)

moviepy/audio/io/ffmpeg_audiowriter.py

@@ -2,13 +2,9 @@
 import numpy as np
 import subprocess as sp
 
-from moviepy.compat import PY3
+from moviepy.compat import PY3, DEVNULL
 
 import os
-if PY3:
-    from subprocess import DEVNULL # py3k
-else:
-    DEVNULL = open(os.devnull, 'wb')
 
 from tqdm import tqdm
 from moviepy.config import get_setting

moviepy/audio/io/readers.py

@@ -6,12 +6,8 @@
 
 from moviepy.video.io.ffmpeg_reader import ffmpeg_parse_infos
 from moviepy.config import get_setting
-from moviepy.compat import PY3
+from moviepy.compat import PY3, DEVNULL
 import os
-if PY3:
-    from subprocess import DEVNULL  # py3k
-else:
-    DEVNULL = open(os.devnull, 'wb')
 
 
 class FFMPEG_AudioReader:

moviepy/compat.py

@@ -1,2 +1,8 @@
+import os
 import sys
 PY3=sys.version_info.major >= 3
+
+if PY3:
+   from subprocess import DEVNULL  # py3k
+else:
+   DEVNULL = open(os.devnull, 'wb')

moviepy/config.py

@@ -1,9 +1,6 @@
 import os
 import subprocess as sp
-try:
-    from subprocess import DEVNULL  # py3k
-except ImportError:
-    DEVNULL = open(os.devnull, 'wb')
+from .compat import DEVNULL
 
 if os.name == 'nt':
     try:    
@@ -103,5 +100,3 @@ def change_settings(new_settings={}, file=None):
         print( "MoviePy : ImageMagick successfully found." )
     else:
         print( "MoviePy : can't find or access ImageMagick." )
-
-

moviepy/tools.py

@@ -8,10 +8,7 @@
 import re
 
 import os
-try:
-    from subprocess import DEVNULL  # py3k
-except ImportError:
-    DEVNULL = open(os.devnull, 'wb')
+from .compat import DEVNULL
 
 
 def sys_write_flush(s):
@@ -156,4 +153,4 @@ def find_extension(codec):
     for ext,infos in extensions_dict.items():
         if ('codec' in infos) and codec in infos['codec']:
             return ext
-    raise ValueError
+    raise ValueError

moviepy/video/VideoClip.py

@@ -40,11 +40,7 @@
                           convert_masks_to_RGB,
                           use_clip_fps_by_default)
 
-from ..compat import PY3
-try:
-    from subprocess import DEVNULL  # py3k
-except ImportError:
-    DEVNULL = open(os.devnull, 'wb')
+from ..compat import PY3, DEVNULL
 
 
 class VideoClip(Clip):

moviepy/video/io/ffmpeg_reader.py

@@ -15,13 +15,9 @@
 import numpy as np
 from moviepy.config import get_setting  # ffmpeg, ffmpeg.exe, etc...
 from moviepy.tools import cvsecs
-from moviepy.compat import PY3
+from moviepy.compat import PY3, DEVNULL
 
 import os
-if PY3:
-    from subprocess import DEVNULL  # py3k
-else:
-    DEVNULL = open(os.devnull, 'wb')
 
 
 class FFMPEG_VideoReader:

moviepy/video/io/ffmpeg_writer.py

@@ -7,13 +7,7 @@
 import os
 import numpy as np
 
-from moviepy.compat import PY3
-
-if PY3:
-    from subprocess import DEVNULL  # py3k
-else:
-    DEVNULL = open(os.devnull, 'wb')
-
+from moviepy.compat import PY3, DEVNULL
 from moviepy.config import get_setting
 from moviepy.tools import verbose_print
 

moviepy/video/io/gif_writers.py

@@ -6,10 +6,7 @@
 from moviepy.tools import verbose_print, subprocess_call
 import numpy as np
 
-try:
-    from subprocess import DEVNULL  # py3k
-except ImportError:
-    DEVNULL = open(os.devnull, 'wb')
+from moviepy.compat import DEVNULL
 
 try:
   import imageio