Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting code with Black #1097

Closed
mgaitan opened this issue Mar 6, 2020 · 2 comments
Closed

Formatting code with Black #1097

mgaitan opened this issue Mar 6, 2020 · 2 comments
Labels
project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta".

Comments

@mgaitan
Copy link
Collaborator

mgaitan commented Mar 6, 2020

I propose to enforce code formatting with Black

Consider the arguments developed in https://github.com/django/deps/blob/master/accepted/0008-black.rst

  • There's no debate about the usefulness of readable code formatting.
  • With automated code formatting, this workload can be transferred to computers, saving human bandwidth for higher value-added activities.
  • It's about making our Python code look as much as possible like what everyone else in the Python community writes.
@tburrows13
Copy link
Collaborator

Yes please! I suppose the best way would be to run it on the entire project locally and submit that as a PR. Then use some tool like https://github.com/marketplace/actions/black-code-formatter to keep it consistent?

@tburrows13 tburrows13 added the project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". label Mar 6, 2020
@mgaitan
Copy link
Collaborator Author

mgaitan commented Mar 15, 2020

Implemented here mgaitan#1

I'll open the proper PR after #1077 be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta".
Projects
None yet
Development

No branches or pull requests

2 participants