Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageClip's with default settings can not be concatenated #314

Closed
AlexanderNickolsky opened this issue Sep 10, 2016 · 1 comment
Closed

Comments

@AlexanderNickolsky
Copy link

How to reproduce:
Create two ImageClips from images. Pass them as arguments to concatenate_videoclips.
The result is an error.

The reason is somewhat complicated. The ImageClip, created with default settings, has a mask. A mask is itself a clip and has no duration attribute. These masks are concatenated using the same concatenate_videoclips functions which requires duration attribute.

Possible fix. There are many possible ways of fixing this, but the simplest is to set duration attribute of the mask clip in VideoClip.py

            elif transparent:
                self.mask = ImageClip(
                    1.0 * img[:, :, 3] / 255, ismask=True, **duration=duration** )
@ghost
Copy link

ghost commented Mar 13, 2017

@AlexanderNickolsky .. I believe this is fixed now.. Can you reopen if, if it persists?

@ghost ghost closed this as completed Mar 13, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant