Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 8 Error #34

Closed
ghost opened this issue Apr 17, 2014 · 9 comments
Closed

Windows 8 Error #34

ghost opened this issue Apr 17, 2014 · 9 comments

Comments

@ghost
Copy link

ghost commented Apr 17, 2014

I am reporting here by Zulko's permission.

http://zulko.github.io/blog/2014/01/23/making-animated-gifs-from-video-files-with-python/#comment-1342388341

I use below code:

import os
from moviepy.editor import *
files = sorted( os.listdir("clips/") )
clips = [ VideoFileClip('clips/%s'%f) for f in files]
video = concatenate(clips)
video.to_videofile("demos.mp4",fps=25, codec="mpeg4")

If there is only one mp4 in clips folder, script works ok and demos.mp4 created. But if there are two mp4 videos in clips folder, script throws error. Output is below:

MoviePy: building video file demos.mp4
----------------------------------------
Writing audio in TEMP_MPY_to_videofile_SOUND_demos.ogg

|----------| 0/952   0% [elapsed: 00:00 left: ?, ? iters/sec]
|#---------| 113/952  11% [elapsed: 00:00 left: 00:05, 165.93 iters/sec]
|##--------| 214/952  22% [elapsed: 00:01 left: 00:04, 181.20 iters/sec]
|###-------| 300/952  31% [elapsed: 00:01 left: 00:03, 177.51 iters/sec]
|####------| 420/952  44% [elapsed: 00:02 left: 00:02, 191.78 iters/sec]
|#####-----| 551/952  57% [elapsed: 00:02 left: 00:01, 204.68 iters/sec]
|#######---| 672/952  70% [elapsed: 00:03 left: 00:01, 210.39 iters/sec]
|########--| 797/952  83% [elapsed: 00:03 left: 00:00, 215.41 iters/sec]
|#########-| 920/952  96% [elapsed: 00:04 left: 00:00, 218.74 iters/sec]

Done writing Audio in TEMP_MPY_to_videofile_SOUND_demos.ogg !

Writing video into TEMP_MPY_to_videofile_demos.mp4

|----------| 0/1078   0% [elapsed: 00:00 left: ?, ? iters/sec]
|----------| 38/1078   3% [elapsed: 00:00 left: 00:14, 72.66 iters/sec]
|----------| 83/1078   7% [elapsed: 00:01 left: 00:12, 80.74 iters/sec]
|#---------| 130/1078  12% [elapsed: 00:01 left: 00:11, 84.75 iters/sec]
|#---------| 173/1078  16% [elapsed: 00:02 left: 00:10, 84.97 iters/sec]
|##--------| 216/1078  20% [elapsed: 00:02 left: 00:10, 84.91 iters/sec]
|##--------| 263/1078  24% [elapsed: 00:03 left: 00:09, 86.31 iters/sec]
|##--------| 312/1078  28% [elapsed: 00:03 left: 00:08, 87.96 iters/sec]
|###-------| 351/1078  32% [elapsed: 00:04 left: 00:08, 86.62 iters/sec]
|###-------| 399/1078  37% [elapsed: 00:04 left: 00:07, 87.58 iters/sec]
|####------| 434/1078  40% [elapsed: 00:05 left: 00:07, 85.77 iters/sec]
|####------| 475/1078  44% [elapsed: 00:05 left: 00:07, 85.39 iters/sec]
|####------| 514/1078  47% [elapsed: 00:06 left: 00:06, 84.72 iters/sec]
Traceback (most recent call last):
  File "C:\Users\slome\Desktop\text.py", line 6, in <module>
    video.to_videofile("demos.mp4",fps=25, codec="mpeg4")
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.15-py2.7.egg\moviepy\video\VideoClip.py", line 282, in to_videofile
    verbose=verbose)
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.15-py2.7.egg\moviepy\video\io\ffmpeg_writer.py", line 136, in ffmpeg_write_video
    frame = clip.get_frame(1.0*i/fps)
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.15-py2.7.egg\moviepy\video\compositing\concatenate.py", line 64, in gf
    return clipslist[i].get_frame(t - tt[i])
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.15-py2.7.egg\moviepy\video\io\VideoFileClip.py", line 66, in <lambda>
    self.get_frame = lambda t: self.reader.get_frame(t)
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.15-py2.7.egg\moviepy\video\io\ffmpeg_reader.py", line 156, in get_frame
    result = self.read_frame()
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.15-py2.7.egg\moviepy\video\io\ffmpeg_reader.py", line 118, in read_frame
    assert len(s) == nbytes
AssertionError

Could you look into this please?

@Zulko
Copy link
Owner

Zulko commented Apr 18, 2014

You don't need authorization to raise an issue :)

Thanks for the feedback, this is a real bug. Looks like my last changes in the program messed things a little. It looks like an easy fix, I'll see that tonight (in circa 10 hours).

@ghost
Copy link
Author

ghost commented Apr 18, 2014

Thank you so much Zulko for looking into this. You have a great coding skills. I am sure you will fix it easily.

@Zulko
Copy link
Owner

Zulko commented Apr 18, 2014

I think I have solved the problem (at least it works fine on my computer). Try reinstalling the module and tell me if it works.

@ghost
Copy link
Author

ghost commented Apr 18, 2014

Hi Zulko,

Thank you very much for your time on this.

I am so sorry to say, it is not working. I used same script above and it throwed below output:

MoviePy: building video file demos.mp4
----------------------------------------
Writing audio in demosTEMP_MPY_to_videofile_SOUNDogg

|----------| 0/476   0% [elapsed: 00:00 left: ?, ? iters/sec]
Traceback (most recent call last):
  File "C:\Users\slome\Desktop\text.py", line 6, in <module>
    video.to_videofile("demos.mp4",fps=25, codec="mpeg4")
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.16-py2.7.egg\moviepy\video\VideoClip.py", line 275, in to_videofile
    verbose)
  File "<string>", line 2, in to_audiofile
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.16-py2.7.egg\moviepy\decorators.py", line 60, in requires_duration
    return f(clip, *a, **k)
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.16-py2.7.egg\moviepy\audio\AudioClip.py", line 104, in to_audiofile
    codec, bitrate, verbose)
  File "<string>", line 2, in ffmpeg_audiowrite
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.16-py2.7.egg\moviepy\decorators.py", line 60, in requires_duration
    return f(clip, *a, **k)
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.16-py2.7.egg\moviepy\audio\io\ffmpeg_audiowriter.py", line 101, in ffmpeg_audiowrite
    writer.write_frames(sndarray)
  File "C:\Python27\lib\site-packages\moviepy-0.2.1.7.16-py2.7.egg\moviepy\audio\io\ffmpeg_audiowriter.py", line 62, in write_frames
    self.proc.stdin.write(frames_array.tostring())
IOError: [Errno 32] Broken pipe

Just as a note, previous version were working fine for one video but this version does not work one video file, too. I hope it helps track the bug.

Cheers

@Zulko
Copy link
Owner

Zulko commented Apr 18, 2014

Ah, I made a typo just before pushing the code, sorry for that. Could you please try it again (reinstall and retry the same code). There are good chances that it will work now.

@ghost
Copy link
Author

ghost commented Apr 18, 2014

no worries,

it stucks at some percentage without throwing any error

MoviePy: building video file demos.mp4
----------------------------------------
Writing audio in demosTEMP_MPY_to_videofile_SOUND.ogg

|----------| 0/5001   0% [elapsed: 00:00 left: ?, ? iters/sec]
|----------| 113/5001   2% [elapsed: 00:00 left: 00:26, 185.55 iters/sec]
|----------| 228/5001   4% [elapsed: 00:01 left: 00:23, 202.85 iters/sec]
|----------| 323/5001   6% [elapsed: 00:01 left: 00:23, 197.19 iters/sec]
|----------| 448/5001   8% [elapsed: 00:02 left: 00:21, 208.08 iters/sec]
|#---------| 549/5001  10% [elapsed: 00:02 left: 00:21, 206.94 iters/sec]
|#---------| 669/5001  13% [elapsed: 00:03 left: 00:20, 212.18 iters/sec]
|#---------| 779/5001  15% [elapsed: 00:03 left: 00:19, 212.44 iters/sec]
|#---------| 898/5001  17% [elapsed: 00:04 left: 00:19, 214.78 iters/sec]
|##--------| 1011/5001  20% [elapsed: 00:04 left: 00:18, 215.29 iters/sec]
|##--------| 1129/5001  22% [elapsed: 00:05 left: 00:17, 216.66 iters/sec]
|##--------| 1269/5001  25% [elapsed: 00:05 left: 00:16, 221.62 iters/sec]
|##--------| 1386/5001  27% [elapsed: 00:06 left: 00:16, 222.12 iters/sec]
|###-------| 1508/5001  30% [elapsed: 00:06 left: 00:15, 223.24 iters/sec]
|###-------| 1661/5001  33% [elapsed: 00:07 left: 00:14, 228.47 iters/sec]
|###-------| 1768/5001  35% [elapsed: 00:07 left: 00:14, 227.10 iters/sec]
|###-------| 1900/5001  37% [elapsed: 00:08 left: 00:13, 228.50 iters/sec]
|####------| 2020/5001  40% [elapsed: 00:08 left: 00:13, 228.77 iters/sec]
|####------| 2135/5001  42% [elapsed: 00:09 left: 00:12, 228.46 iters/sec]
|####------| 2264/5001  45% [elapsed: 00:09 left: 00:11, 229.61 iters/sec]
|####------| 2403/5001  48% [elapsed: 00:10 left: 00:11, 231.64 iters/sec]
|#####-----| 2546/5001  50% [elapsed: 00:10 left: 00:10, 234.14 iters/sec]
|#####-----| 2631/5001  52% [elapsed: 00:11 left: 00:10, 231.03 iters/sec]
|#####-----| 2751/5001  55% [elapsed: 00:11 left: 00:09, 231.41 iters/sec]
|#####-----| 2877/5001  57% [elapsed: 00:12 left: 00:09, 231.94 iters/sec]
|######----| 3005/5001  60% [elapsed: 00:12 left: 00:08, 232.64 iters/sec]
|######----| 3141/5001  62% [elapsed: 00:13 left: 00:07, 233.84 iters/sec]
|######----| 3263/5001  65% [elapsed: 00:13 left: 00:07, 233.96 iters/sec]
|######----| 3363/5001  67% [elapsed: 00:14 left: 00:07, 232.56 iters/sec]
|######----| 3464/5001  69% [elapsed: 00:14 left: 00:06, 231.54 iters/sec]
|#######---| 3578/5001  71% [elapsed: 00:15 left: 00:06, 231.20 iters/sec]
|#######---| 3704/5001  74% [elapsed: 00:15 left: 00:05, 231.64 iters/sec]
|#######---| 3831/5001  76% [elapsed: 00:16 left: 00:05, 232.11 iters/sec]
|#######---| 3973/5001  79% [elapsed: 00:17 left: 00:04, 233.43 iters/sec]
|########--| 4081/5001  81% [elapsed: 00:17 left: 00:03, 232.73 iters/sec]
|########--| 4209/5001  84% [elapsed: 00:18 left: 00:03, 233.20 iters/sec]
|########--| 4300/5001  85% [elapsed: 00:18 left: 00:03, 231.63 iters/sec]
|########--| 4435/5001  88% [elapsed: 00:19 left: 00:02, 232.45 iters/sec]

can you upload your video files so that i can try and make sure bug is not about my videos and codecs?

@Zulko
Copy link
Owner

Zulko commented Apr 19, 2014

Some people had the same problem with the video generation and it seems that we fixed it. Apparently your problem is now with the audio generation, so I just made similar changes to the audio section of the code, and now there are good chances that it will work. Could you try reinstalling moviepy and rerunning the script ?

Thanks for your feedbacks, it's really appreciated.

@ghost
Copy link
Author

ghost commented Apr 19, 2014

hi Zulko, works perfect now. thank you for your time on this.

@Zulko
Copy link
Owner

Zulko commented Apr 20, 2014

Very cool. The program is still young but it is getting better, most bugs come (came ?) from reading and writing video/audio but they are fixed after one another. Have fun.

Cheers,

@Zulko Zulko closed this as completed Apr 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant