Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Travis tester seems to be failing #406

Closed
tburrows13 opened this issue Feb 14, 2017 · 8 comments
Closed

The Travis tester seems to be failing #406

tburrows13 opened this issue Feb 14, 2017 · 8 comments

Comments

@tburrows13
Copy link
Collaborator

Currently both pull requests (mine and this one) that have been submitted since the Travis testing suite was implemented have failed their tests. I think this is a fault of the tester or the test cases, as there appears to be no problem in the PR code.

My PR literally added 1 line of code, which has no reason to fail.

@Zulko
Copy link
Owner

Zulko commented Feb 14, 2017

The reason it failed is that moviepy is registered with Travis, although there is no test suite yet.

@Zulko Zulko closed this as completed Feb 14, 2017
@Zulko
Copy link
Owner

Zulko commented Feb 15, 2017

@mbeacom are you working on a test suite ? Otherwise I would propose that I just start a very minimal test suite with a super-naive test, just to make sure that PRs are at least syntatically correct.

Would Pytest be ok for the test suite ?

@Zulko
Copy link
Owner

Zulko commented Feb 18, 2017

@mbeacom are you working on a test suite ? Otherwise I am happy to start one ? Would Pytest be ok ?

@ghost
Copy link

ghost commented Feb 23, 2017

I've added some tests in the test directory. Can we set this up to use Travis?

@ghost ghost reopened this Feb 23, 2017
@ghost
Copy link

ghost commented Feb 26, 2017

I've added a .travis.yml file to my forked repo earney/moviepy, and it is passing on travis-ci. Feel free to use the .travis.yml and (test cases in the test directory as a starting point).

I will do this if no one else wants to. @Zulko made a statement that he was going to work on this issue this weekend.

@Zulko
Copy link
Owner

Zulko commented Feb 26, 2017

My plan was to troubleshoot Travis but if your .travis.yml already works, feel free to go ahead and merge (maybe clean the comments).

@ghost
Copy link

ghost commented Feb 26, 2017

sure thing!

@ghost
Copy link

ghost commented Mar 6, 2017

closing with travis has been working for a week or so.

@ghost ghost closed this as completed Mar 6, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants